2015-02-10  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: Crash inspecting styles of element with mutated stylesheet

        https://bugs.webkit.org/show_bug.cgi?id=141451

        Reviewed by NOBODY (OOPS!).

        * inspector/css/stylesheet-with-mutations-expected.txt: Added.

        * inspector/css/stylesheet-with-mutations.html: Added.

        Previously this test would crash, or in debug builds show one

        of the two selectors in the rule.

Testing that we get expected values for selectors after CSSOM stylesheet modifications.

.foo

.bar

<!DOCTYPE html>

<html>

<head>

<style>

.foo, .bar { color: red; }

</style>

<script type="text/javascript" src="../../http/tests/inspector/inspector-test.js"></script>

<script>

// Insert a rule at the beginning of the inline stylesheet above that would shift all rule ordinals down.

document.styleSheets[0].insertRule("body { padding: 10px; }", 0);

function test() {

    var nodeStyles;

    function validateSelectors()

    {

        for (var i = 0; i < nodeStyles.matchedRules.length; ++i) {

            var rule = nodeStyles.matchedRules[i];

            if (rule.type !== WebInspector.CSSRule.Type.Author)

                continue;

            for (var selector of rule.selectors)

                InspectorTest.log(selector.text);

        }

        InspectorTest.completeTest();

    }

    function onStylesRefreshed()

    {

        nodeStyles.removeEventListener(WebInspector.DOMNodeStyles.Event.Refreshed, onStylesRefreshed, this);

        validateSelectors();

    }

    WebInspector.domTreeManager.requestDocument(function(documentNode) {

        WebInspector.domTreeManager.querySelector(documentNode.id, ".bar", function(contentNodeId) {

            if (contentNodeId) {

                var domNode = WebInspector.domTreeManager.nodeForId(contentNodeId);

                nodeStyles = WebInspector.cssStyleManager.stylesForNode(domNode);

                if (nodeStyles.needsRefresh)

                    nodeStyles.addEventListener(WebInspector.DOMNodeStyles.Event.Refreshed, onStylesRefreshed, this);

                else

                    validateSelectors();

            } else {

                InspectorTest.log("DOM node not found.");

                InspectorTest.completeTest();

            }

        });

    });

}

</script>

</head>

<body onload="runTest()">

    <p>Testing that we get expected values for selectors after a stylesheet has mutations.</p>

    <div class="bar"></div>

</body>

</html>

2015-02-10  Joseph Pecoraro  <pecoraro@apple.com>

        Web Inspector: Crash inspecting styles of element with mutated stylesheet

        https://bugs.webkit.org/show_bug.cgi?id=141451

        Reviewed by NOBODY (OOPS!).

        Test: inspector/css/stylesheet-with-mutations.html

        * css/CSSStyleSheet.h:

        * css/CSSStyleSheet.cpp:

        (WebCore::CSSStyleSheet::CSSStyleSheet):

        (WebCore::CSSStyleSheet::didMutateRules):

        Keep a flag on the CSSStyleSheet to know when it has had a rule

        mutation from the contents.

        * inspector/InspectorStyleSheet.h:

        * inspector/InspectorStyleSheet.cpp:

        (WebCore::InspectorStyleSheet::reparseStyleSheet):

        When completely replacing the stylesheet's contents, we will have

        destroyed any previous rules, so clear the has mutations flag.

        (WebCore::selectorsFromSource):

        Previously there was a mismatch between the rules the parsed

        SourceData had, and the actual CSSSelectors we were iterating.

        We use the SourceData so we can get the exact user authored

        text instead of generated longhands from actualy selector objects.

        Add an ASSERT and bail to catch and more gracefully handle

        any possible mismatches in the future.

        (WebCore::InspectorStyleSheet::styleSheetMutated):

        (WebCore::InspectorStyleSheet::ensureParsedDataReady):

        When a CSSStyleSheet has been mutated beyond the inspector's

        knowledge right now, fall back to readonly generated selectors.

        We should better handle this in the future:

        <https://webkit.org/b/141450> Web Inspector: Better support for CSSOM StyleSheet mutations (insertRule/deleteRule)

    , m_mutatedRules(false)

    , m_mutatedRules(false)

    m_mutatedRules = true;

    bool hadRulesMutation() const { return m_mutatedRules; }

    void clearHadRulesMutation() { m_mutatedRules = false; }

    bool m_mutatedRules;

    // We just wiped the entire contents of the stylesheet. Clear the mutation flag.

    m_pageStyleSheet->clearHadRulesMutation();

        // If we don't have a selector, that means the SourceData for this CSSStyleSheet

        // no longer matches up with the actual rules in the CSSStyleSheet.

        ASSERT(selector);

        if (!selector)

            break;

bool InspectorStyleSheet::styleSheetMutated() const

{

    return m_pageStyleSheet && m_pageStyleSheet->hadRulesMutation();

}

    bool styleSheetMutated() const;