Attachment #243485 for bug #139766

View Details Raw Unified Return to Bug 139766



2014-12-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Internals methods return 0 instead of false when they fail
        https://bugs.webkit.org/show_bug.cgi?id=139766

        Reviewed by NOBODY (OOPS!).

        Some Internals method explicitly return 0 although
        they expect boolean value.

        No new tests, no behavior change.

        * testing/Internals.cpp:
        (WebCore::Internals::hasSpellingMarker):
        (WebCore::Internals::hasAutocorrectedMarker):
        (WebCore::Internals::isOverwriteModeEnabled):
        (WebCore::Internals::hasGrammarMarker):
        Return false instead of 0.

2014-12-17  Csaba Osztrogonác  <ossy@webkit.org>

        URTBF after r177452.



{
    Document* document = contextDocument();
    if (!document || !document->frame())
        return false;

    updateEditorUINowIfScheduled();


{
    Document* document = contextDocument();
    if (!document || !document->frame())
        return false;

    updateEditorUINowIfScheduled();


{
    Document* document = contextDocument();
    if (!document || !document->frame())
        return false;

    return document->frame()->editor().isOverwriteModeEnabled();
}

{
    Document* document = contextDocument();
    if (!document || !document->frame())
        return false;

    return document->frame()->editor().selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
}

Return to Bug 139766

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +19 lines
		1	2014-12-18 Grzegorz Czajkowski <g.czajkowski@samsung.com>
		2
		3	Internals methods return 0 instead of false when they fail
		4	https://bugs.webkit.org/show_bug.cgi?id=139766
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Some Internals method explicitly return 0 although
		9	they expect boolean value.
		10
		11	No new tests, no behavior change.
		12
		13	* testing/Internals.cpp:
		14	(WebCore::Internals::hasSpellingMarker):
		15	(WebCore::Internals::hasAutocorrectedMarker):
		16	(WebCore::Internals::isOverwriteModeEnabled):
		17	(WebCore::Internals::hasGrammarMarker):
		18	Return false instead of 0.
		19
1	2014-12-17 Csaba Osztrogonác <ossy@webkit.org>	20	2014-12-17 Csaba Osztrogonác <ossy@webkit.org>
2		21
3	URTBF after r177452.	22	URTBF after r177452.

Lines 1335-1341 bool Internals::hasSpellingMarker(int from, int length, ExceptionCode&) a/Source/WebCore/testing/Internals.cpp_sec1
- a/Source/WebCore/testing/Internals.cpp -4 / +4 lines
1335	{	1335	{
1336	Document* document = contextDocument();	1336	Document* document = contextDocument();
1337	if (!document \|\| !document->frame())	1337	if (!document \|\| !document->frame())
1338	return 0;	1338	return false;
1339		1339
1340	updateEditorUINowIfScheduled();	1340	updateEditorUINowIfScheduled();
1341		1341
Lines 1346-1352 bool Internals::hasAutocorrectedMarker(int from, int length, ExceptionCode&) a/Source/WebCore/testing/Internals.cpp_sec2
1346	{	1346	{
1347	Document* document = contextDocument();	1347	Document* document = contextDocument();
1348	if (!document \|\| !document->frame())	1348	if (!document \|\| !document->frame())
1349	return 0;	1349	return false;
1350		1350
1351	updateEditorUINowIfScheduled();	1351	updateEditorUINowIfScheduled();
1352		1352
Lines 1431-1437 bool Internals::isOverwriteModeEnabled(ExceptionCode&) a/Source/WebCore/testing/Internals.cpp_sec3
1431	{	1431	{
1432	Document* document = contextDocument();	1432	Document* document = contextDocument();
1433	if (!document \|\| !document->frame())	1433	if (!document \|\| !document->frame())
1434	return 0;	1434	return false;
1435		1435
1436	return document->frame()->editor().isOverwriteModeEnabled();	1436	return document->frame()->editor().isOverwriteModeEnabled();
1437	}	1437	}
Lines 1561-1567 bool Internals::hasGrammarMarker(int from, int length, ExceptionCode&) a/Source/WebCore/testing/Internals.cpp_sec4
1561	{	1561	{
1562	Document* document = contextDocument();	1562	Document* document = contextDocument();
1563	if (!document \|\| !document->frame())	1563	if (!document \|\| !document->frame())
1564	return 0;	1564	return false;
1565		1565
1566	return document->frame()->editor().selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);	1566	return document->frame()->editor().selectionStartHasMarkerFor(DocumentMarker::Grammar, from, length);
1567	}	1567	}