Attachment #226034 for bug #129813

View Details Raw Unified Return to Bug 129813

| Differences between



2014-03-06  Mark Lam  <mark.lam@apple.com>

        REGRESSION(r165205): broke the CLOOP build (Requested by smfr on #webkit).
        <https://webkit.org/b/129813>

        Reviewed by Michael Saboff.

        Fixed broken C loop LLINT build.

        * llint/LowLevelInterpreter.cpp:
        (JSC::CLoop::execute):
        * offlineasm/cloop.rb:

2014-03-03  Oliver Hunt  <oliver@apple.com>

        Support caching of custom setters

Lines 325-331 JSValue CLoop::execute(OpcodeID entryOpc Source/JavaScriptCore/llint/LowLevelInterpreter.cpp_sec1
- Source/JavaScriptCore/llint/LowLevelInterpreter.cpp -1 / +1 lines
325	// 2. 32 bit result values will be in the low 32-bit of t0.	325	// 2. 32 bit result values will be in the low 32-bit of t0.
326	// 3. 64 bit result values will be in t0.	326	// 3. 64 bit result values will be in t0.
327		327
328	CLoopRegister t0, t1, t2, t3, t5, sp, cfr, lr, pc;	328	CLoopRegister t0, t1, t2, t3, t5, t7, sp, cfr, lr, pc;
329	#if USE(JSVALUE64)	329	#if USE(JSVALUE64)
330	CLoopRegister pcBase, tagTypeNumber, tagMask;	330	CLoopRegister pcBase, tagTypeNumber, tagMask;
331	#endif	331	#endif

Lines 84-89 class RegisterID Source/JavaScriptCore/offlineasm/cloop.rb_sec1
- Source/JavaScriptCore/offlineasm/cloop.rb +2 lines
84	"t5"	84	"t5"
85	when "t6"	85	when "t6"
86	"pcBase"	86	"pcBase"
		87	when "t7"
		88	"t7"
87	when "csr1"	89	when "csr1"
88	"tagTypeNumber"	90	"tagTypeNumber"
89	when "csr2"	91	when "csr2"

Return to Bug 129813

Lines 1-3 Source/JavaScriptCore/ChangeLog_sec1
- Source/JavaScriptCore/ChangeLog +13 lines
		1	2014-03-06 Mark Lam <mark.lam@apple.com>
		2
		3	REGRESSION(r165205): broke the CLOOP build (Requested by smfr on #webkit).
		4	<https://webkit.org/b/129813>
		5
		6	Reviewed by Michael Saboff.
		7
		8	Fixed broken C loop LLINT build.
		9
		10	* llint/LowLevelInterpreter.cpp:
		11	(JSC::CLoop::execute):
		12	* offlineasm/cloop.rb:
		13
1	2014-03-03 Oliver Hunt <oliver@apple.com>	14	2014-03-03 Oliver Hunt <oliver@apple.com>
2		15
3	Support caching of custom setters	16	Support caching of custom setters