Attachment #225357 for bug #129420

View Details Raw Unified Return to Bug 129420



2014-02-27  Julien Brianceau   <jbriance@cisco.com>

        Fix 32-bit V_JITOperation_EJ callOperation introduced in r162652.
        https://bugs.webkit.org/show_bug.cgi?id=129420

        Reviewed by NOBODY (OOPS!).

        * dfg/DFGSpeculativeJIT.h:
        (JSC::DFG::SpeculativeJIT::callOperation): Payload and tag are swapped.
        Also, EABI_32BIT_DUMMY_ARG is missing for arm EABI and mips.

2014-02-27  Mark Hahnenberg  <mhahnenberg@apple.com>

        r164764 broke the ARM build

Lines 1640-1646 public: Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h_sec1
- Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h -1 / +1 lines
1640		1640
1641	JITCompiler::Call callOperation(V_JITOperation_EJ operation, GPRReg arg1Tag, GPRReg arg1Payload)	1641	JITCompiler::Call callOperation(V_JITOperation_EJ operation, GPRReg arg1Tag, GPRReg arg1Payload)
1642	{	1642	{
1643	m_jit.setupArgumentsWithExecState(arg1Tag, arg1Payload);	1643	m_jit.setupArgumentsWithExecState(EABI_32BIT_DUMMY_ARG arg1Payload, arg1Tag);
1644	return appendCallWithExceptionCheck(operation);	1644	return appendCallWithExceptionCheck(operation);
1645	}	1645	}
1646		1646

Return to Bug 129420

Lines 1-3 Source/JavaScriptCore/ChangeLog_sec1
- Source/JavaScriptCore/ChangeLog +11 lines
		1	2014-02-27 Julien Brianceau <jbriance@cisco.com>
		2
		3	Fix 32-bit V_JITOperation_EJ callOperation introduced in r162652.
		4	https://bugs.webkit.org/show_bug.cgi?id=129420
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* dfg/DFGSpeculativeJIT.h:
		9	(JSC::DFG::SpeculativeJIT::callOperation): Payload and tag are swapped.
		10	Also, EABI_32BIT_DUMMY_ARG is missing for arm EABI and mips.
		11
1	2014-02-27 Mark Hahnenberg <mhahnenberg@apple.com>	12	2014-02-27 Mark Hahnenberg <mhahnenberg@apple.com>
2		13
3	r164764 broke the ARM build	14	r164764 broke the ARM build