Attachment #224484 for bug #128962

View Details Raw Unified Return to Bug 128962



2014-02-18  Zan Dobersek  <zdobersek@igalia.com>

        Remove unnecessary UserActionElementSet constructor, destructor
        https://bugs.webkit.org/show_bug.cgi?id=128962

        Reviewed by NOBODY (OOPS!).

        UserActionElementSet constructor and destructor are not necessary, as is not the
        static create() function that returns PassOwnPtr<UserActionElementSet>. The implicit
        constructor and destructor can take care of creating and destroying the sole HashMap
        member variable.

        * dom/UserActionElementSet.cpp:
        * dom/UserActionElementSet.h:

2014-02-11  Benjamin Poulain  <benjamin@webkit.org>

        querySelector() does not use the compiler correctly




namespace WebCore {

UserActionElementSet::UserActionElementSet()
{
}

UserActionElementSet::~UserActionElementSet()
{
}

void UserActionElementSet::didDetach(Element* element)
{
    ASSERT(element->isUserActionElement());



#define UserActionElementSet_h

#include <wtf/HashMap.h>
#include <wtf/OwnPtr.h>
#include <wtf/PassOwnPtr.h>
#include <wtf/PassRefPtr.h>
#include <wtf/RefPtr.h>



class UserActionElementSet {
public:
    static PassOwnPtr<UserActionElementSet> create() { return adoptPtr(new UserActionElementSet()); }

    bool isFocused(const Element* element) { return hasFlags(element, IsFocusedFlag); }
    bool isActive(const Element* element) { return hasFlags(element, IsActiveFlag); }
    bool isInActiveChain(const Element* element) { return hasFlags(element, InActiveChainFlag); }

    void setInActiveChain(Element* element, bool enable) { setFlags(element, enable, InActiveChainFlag); }
    void setHovered(Element* element, bool enable) { setFlags(element, enable, IsHoveredFlag); }

    UserActionElementSet();
    ~UserActionElementSet();

    void didDetach(Element*);
    void documentDidRemoveLastRef();


Return to Bug 128962

Lines 32-45 a/Source/WebCore/dom/UserActionElementSet.cpp_sec1
- a/Source/WebCore/dom/UserActionElementSet.cpp -8 lines
32		32
33	namespace WebCore {	33	namespace WebCore {
34		34
35	UserActionElementSet::UserActionElementSet()
36	{
37	}
38
39	UserActionElementSet::~UserActionElementSet()
40	{
41	}
42
43	void UserActionElementSet::didDetach(Element* element)	35	void UserActionElementSet::didDetach(Element* element)
44	{	36	{
45	ASSERT(element->isUserActionElement());	37	ASSERT(element->isUserActionElement());

Lines 29-36 a/Source/WebCore/dom/UserActionElementSet.h_sec1
- a/Source/WebCore/dom/UserActionElementSet.h -7 lines
29	#define UserActionElementSet_h	29	#define UserActionElementSet_h
30		30
31	#include <wtf/HashMap.h>	31	#include <wtf/HashMap.h>
32	#include <wtf/OwnPtr.h>
33	#include <wtf/PassOwnPtr.h>
34	#include <wtf/PassRefPtr.h>	32	#include <wtf/PassRefPtr.h>
35	#include <wtf/RefPtr.h>	33	#include <wtf/RefPtr.h>
36		34
Lines 40-47 class Element; a/Source/WebCore/dom/UserActionElementSet.h_sec2
40		38
41	class UserActionElementSet {	39	class UserActionElementSet {
42	public:	40	public:
43	static PassOwnPtr<UserActionElementSet> create() { return adoptPtr(new UserActionElementSet()); }
44
45	bool isFocused(const Element* element) { return hasFlags(element, IsFocusedFlag); }	41	bool isFocused(const Element* element) { return hasFlags(element, IsFocusedFlag); }
46	bool isActive(const Element* element) { return hasFlags(element, IsActiveFlag); }	42	bool isActive(const Element* element) { return hasFlags(element, IsActiveFlag); }
47	bool isInActiveChain(const Element* element) { return hasFlags(element, InActiveChainFlag); }	43	bool isInActiveChain(const Element* element) { return hasFlags(element, InActiveChainFlag); }
Lines 51-59 public: a/Source/WebCore/dom/UserActionElementSet.h_sec3
51	void setInActiveChain(Element* element, bool enable) { setFlags(element, enable, InActiveChainFlag); }	47	void setInActiveChain(Element* element, bool enable) { setFlags(element, enable, InActiveChainFlag); }
52	void setHovered(Element* element, bool enable) { setFlags(element, enable, IsHoveredFlag); }	48	void setHovered(Element* element, bool enable) { setFlags(element, enable, IsHoveredFlag); }
53		49
54	UserActionElementSet();
55	~UserActionElementSet();
56
57	void didDetach(Element*);	50	void didDetach(Element*);
58	void documentDidRemoveLastRef();	51	void documentDidRemoveLastRef();
59		52

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +15 lines
		1	2014-02-18 Zan Dobersek <zdobersek@igalia.com>
		2
		3	Remove unnecessary UserActionElementSet constructor, destructor
		4	https://bugs.webkit.org/show_bug.cgi?id=128962
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	UserActionElementSet constructor and destructor are not necessary, as is not the
		9	static create() function that returns PassOwnPtr<UserActionElementSet>. The implicit
		10	constructor and destructor can take care of creating and destroying the sole HashMap
		11	member variable.
		12
		13	* dom/UserActionElementSet.cpp:
		14	* dom/UserActionElementSet.h:
		15
1	2014-02-11 Benjamin Poulain <benjamin@webkit.org>	16	2014-02-11 Benjamin Poulain <benjamin@webkit.org>
2		17
3	querySelector() does not use the compiler correctly	18	querySelector() does not use the compiler correctly