Attachment #222672 for bug #127911

View Details Raw Unified Return to Bug 127911



2014-01-30  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Only disable -ftree-dce optimization when compiling with GCC
        https://bugs.webkit.org/show_bug.cgi?id=127911

        Reviewed by NOBODY (OOPS!).

        * Source/autotools/SetupAutomake.m4: Define the COMPILER_GCC and COMPILER_CLANG Automake macros.
        These can be used when compiler-specific flags have to be used. The latter one is not actually needed
        at the moment, but is added for the sake of completeness.

2014-01-30  Csaba Osztrogonác  <ossy@webkit.org>

        [EFL] Fix the regression caused by the jsCStack branch merge



2014-01-30  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Only disable -ftree-dce optimization when compiling with GCC
        https://bugs.webkit.org/show_bug.cgi?id=127911

        Reviewed by NOBODY (OOPS!).

        * GNUmakefile.am: Only disable the -ftree-dce optimization when using the GCC compiler.
        Some Clang versions/configurations don't support the flag.

2014-01-30  Zan Dobersek  <zdobersek@igalia.com>

        [GTK] Disable optimizations for JSC that turned out malignant after jsCStack branch merge



	$(global_cppflags) \
	$(javascriptcore_cppflags)

# FIXME: the -fomit-frame-pointer and -ftree-dce optimizations are disabled after they've been causing
# trouble with the merged jsCStack code. The former is required due to otherwise incorrectly compiled
# operationCallEval function, while the second is required when using GCC 4.8 but not when using GCC 4.7,
# possibly due to a bug in that compiler. See bugs #127777 and #127909 for more information.
javascriptcore_cppflags += \
	-I$(srcdir)/Source \
	-I$(srcdir)/Source/JavaScriptCore \

	-I$(srcdir)/Source/JavaScriptCore/yarr \
	-I$(top_builddir)/DerivedSources/JavaScriptCore \
	-I$(srcdir)/Source/WTF \
	-fno-omit-frame-pointer \
	-fno-tree-dce \
	$(LLVM_CFLAGS)

# FIXME: the -fomit-frame-pointer and -ftree-dce optimizations are disabled after they've been causing
# trouble with the merged jsCStack code. The former is required due to otherwise incorrectly compiled
# operationCallEval function, while the latter is required when using GCC 4.8. See bugs #127777 and
# #127909 for more information.
javascriptcore_cppflags += \
	-fno-omit-frame-pointer

if COMPILER_GCC
javascriptcore_cppflags += \
	-fno-tree-dce
endif

javascriptcore_cflags += \
	$(global_cflags) \
	$(GLIB_CFLAGS) \

Lines 22-27 AM_CONDITIONAL([OS_GNU],[test "$os_gnu" Source/autotools/SetupAutomake.m4_sec1
- Source/autotools/SetupAutomake.m4 +3 lines
22	AM_CONDITIONAL([OS_DARWIN],[test "$os_darwin" = "yes"])	22	AM_CONDITIONAL([OS_DARWIN],[test "$os_darwin" = "yes"])
23	AM_CONDITIONAL([OS_FREEBSD],[test "$os_freebsd" = "yes"])	23	AM_CONDITIONAL([OS_FREEBSD],[test "$os_freebsd" = "yes"])
24		24
		25	AM_CONDITIONAL([COMPILER_GCC],[test "$c_compiler" = "gcc" && test "$cxx_compiler" = "g++"])
		26	AM_CONDITIONAL([COMPILER_CLANG],[test "$c_compiler" = "clang" && test "$cxx_compiler" = "clang++"])
		27
25	# Target conditionals.	28	# Target conditionals.
26	AM_CONDITIONAL([TARGET_X11], [test "$enable_x11_target" = "yes"])	29	AM_CONDITIONAL([TARGET_X11], [test "$enable_x11_target" = "yes"])
27	AM_CONDITIONAL([TARGET_WAYLAND], [test "$enable_wayland_target" = "yes"])	30	AM_CONDITIONAL([TARGET_WAYLAND], [test "$enable_wayland_target" = "yes"])

Return to Bug 127911

Lines 1-3 ChangeLog_sec1
- ChangeLog +11 lines
		1	2014-01-30 Zan Dobersek <zdobersek@igalia.com>
		2
		3	[GTK] Only disable -ftree-dce optimization when compiling with GCC
		4	https://bugs.webkit.org/show_bug.cgi?id=127911
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* Source/autotools/SetupAutomake.m4: Define the COMPILER_GCC and COMPILER_CLANG Automake macros.
		9	These can be used when compiler-specific flags have to be used. The latter one is not actually needed
		10	at the moment, but is added for the sake of completeness.
		11
1	2014-01-30 Csaba Osztrogonác <ossy@webkit.org>	12	2014-01-30 Csaba Osztrogonác <ossy@webkit.org>
2		13
3	[EFL] Fix the regression caused by the jsCStack branch merge	14	[EFL] Fix the regression caused by the jsCStack branch merge

Lines 1-3 Source/JavaScriptCore/ChangeLog_sec1
- Source/JavaScriptCore/ChangeLog +10 lines
		1	2014-01-30 Zan Dobersek <zdobersek@igalia.com>
		2
		3	[GTK] Only disable -ftree-dce optimization when compiling with GCC
		4	https://bugs.webkit.org/show_bug.cgi?id=127911
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* GNUmakefile.am: Only disable the -ftree-dce optimization when using the GCC compiler.
		9	Some Clang versions/configurations don't support the flag.
		10
1	2014-01-30 Zan Dobersek <zdobersek@igalia.com>	11	2014-01-30 Zan Dobersek <zdobersek@igalia.com>
2		12
3	[GTK] Disable optimizations for JSC that turned out malignant after jsCStack branch merge	13	[GTK] Disable optimizations for JSC that turned out malignant after jsCStack branch merge

Lines 44-53 libjavascriptcoregtk_@WEBKITGTK_API_MAJO Source/JavaScriptCore/GNUmakefile.am_sec1
- Source/JavaScriptCore/GNUmakefile.am -6 / +12 lines
44	$(global_cppflags) \	44	$(global_cppflags) \
45	$(javascriptcore_cppflags)	45	$(javascriptcore_cppflags)
46		46
47	# FIXME: the -fomit-frame-pointer and -ftree-dce optimizations are disabled after they've been causing
48	# trouble with the merged jsCStack code. The former is required due to otherwise incorrectly compiled
49	# operationCallEval function, while the second is required when using GCC 4.8 but not when using GCC 4.7,
50	# possibly due to a bug in that compiler. See bugs #127777 and #127909 for more information.
51	javascriptcore_cppflags += \	47	javascriptcore_cppflags += \
52	-I$(srcdir)/Source \	48	-I$(srcdir)/Source \
53	-I$(srcdir)/Source/JavaScriptCore \	49	-I$(srcdir)/Source/JavaScriptCore \
Lines 74-83 javascriptcore_cppflags += \ Source/JavaScriptCore/GNUmakefile.am_sec2
74	-I$(srcdir)/Source/JavaScriptCore/yarr \	70	-I$(srcdir)/Source/JavaScriptCore/yarr \
75	-I$(top_builddir)/DerivedSources/JavaScriptCore \	71	-I$(top_builddir)/DerivedSources/JavaScriptCore \
76	-I$(srcdir)/Source/WTF \	72	-I$(srcdir)/Source/WTF \
77	-fno-omit-frame-pointer \
78	-fno-tree-dce \
79	$(LLVM_CFLAGS)	73	$(LLVM_CFLAGS)
80		74
		75	# FIXME: the -fomit-frame-pointer and -ftree-dce optimizations are disabled after they've been causing
		76	# trouble with the merged jsCStack code. The former is required due to otherwise incorrectly compiled
		77	# operationCallEval function, while the latter is required when using GCC 4.8. See bugs #127777 and
		78	# #127909 for more information.
		79	javascriptcore_cppflags += \
		80	-fno-omit-frame-pointer
		81
		82	if COMPILER_GCC
		83	javascriptcore_cppflags += \
		84	-fno-tree-dce
		85	endif
		86
81	javascriptcore_cflags += \	87	javascriptcore_cflags += \
82	$(global_cflags) \	88	$(global_cflags) \
83	$(GLIB_CFLAGS) \	89	$(GLIB_CFLAGS) \