View Details Raw Unified Return to Bug 124481
Collapse All Expand All
- Source/JavaScriptCore/ChangeLog +12 lines
Lines 1-3 Source/JavaScriptCore/ChangeLog_sec1
1 
2013-11-18  Michael Saboff  <msaboff@apple.com>
2 

            

            

              3
              
        ARM64 CRASH: Improper offset in getHostCallReturnValue() to access callerFrame in CallFrame

            

            

              4
              
        https://bugs.webkit.org/show_bug.cgi?id=124481

            

            

              5
              

            

            

              6
              
        Reviewed by NOBODY (OOPS!).

            

            

              7
              

            

            

              8
              
        Fixed the offset to access CallerFrame in the ARM64 version of getHostCallReturnValue() to be 0

            

            

              9
              
        to correspond with the change in CallFrame layout done in r158315.

            

            

              10
              

            

            

              11
              
        * jit/JITOperations.cpp:

            

            

              12
              

            

        

          1
          
2013-11-18  Michael Saboff  <msaboff@apple.com>

          13
          
2013-11-18  Michael Saboff  <msaboff@apple.com>

        

        

          2
          

          14
          

        

        

          3
          
        Crash in virtualForThunkGenerator generated code on ARM64

          15
          
        Crash in virtualForThunkGenerator generated code on ARM64

        



-
  Source/JavaScriptCore/jit/JITOperations.cpp
    
      -1 / +1 lines
    




  

    
      
            Lines 1766-1772
      
      asm (
      
        Source/JavaScriptCore/jit/JITOperations.cpp_sec1
      
    
  

        

          1766
          
".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"

          1766
          
".globl " SYMBOL_STRING(getHostCallReturnValue) "\n"

        

        

          1767
          
HIDE_SYMBOL(getHostCallReturnValue) "\n"

          1767
          
HIDE_SYMBOL(getHostCallReturnValue) "\n"

        

        

          1768
          
SYMBOL_STRING(getHostCallReturnValue) ":" "\n"

          1768
          
SYMBOL_STRING(getHostCallReturnValue) ":" "\n"

        

          
            

              1769
              
    "ldur x25, [x25, #-32]" "\n"


              1769
              
    "ldur x25, [x25, #0]" "\n"

            

        

          1770
          
     "mov x0, x25" "\n"

          1770
          
     "mov x0, x25" "\n"

        

        

          1771
          
     "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"

          1771
          
     "b " LOCAL_REFERENCE(getHostCallReturnValueWithExecState) "\n"

        

        

          1772
          
);

          1772
          
);

        






  

  Return to Bug 124481