Attachment #216594 for bug #122422

View Details Raw Unified Return to Bug 122422

| Differences between



2013-11-11  Zan Dobersek  <zdobersek@igalia.com>

        JSC bindings generator should generate deletable JSC functions
        https://bugs.webkit.org/show_bug.cgi?id=122422

        Reviewed by Geoffrey Garen.

        The JSC functions that the JSC bindings generator generates should be deletable to conform to
        the WebIDL specification, which instructs that the WebIDL operations must be configurable (which
        translates to the JSC functions being deletable).

        The generator will still produce a non-deletable JSC function for operations under almost all
        Web-facing interfaces since they're annotated with the OperationsNotDeletable attribute. The
        exception here is the Node interface that is having the attribute removed, with the provided
        test case testing that all the functions on the Node prototype object are writable, enumerable
        and configurable. This behavior conforms to the WebIDL specification and the behaviors of IE
        and Firefox. Chrome at the moment still provides non-configurable functions.

        Test: fast/dom/webidl-operations-on-node-prototype.html

        * bindings/scripts/CodeGeneratorJS.pm:
        (GenerateImplementation): Enforce the non-deletable behavior of the JSC function if either the
        operation's interface is annotated with the OperationsNotDeletable attribute or the operation itself
        is annotated with the NotDeletable attribute.
        * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Update the JSC generator test baselines.
        * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
        * bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
        * dom/Node.idl: Remove the OperationsNotDeletable attribute.

2013-11-11  Zan Dobersek  <zdobersek@igalia.com>

        Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces



            push(@hashValue2, $functionLength);

            my @specials = ();
            push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
                || $function->signature->extendedAttributes->{"NotDeletable"};
            push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
            push(@specials, "JSC::Function");
            my $special = (@specials > 0) ? join(" | ", @specials) : "0";

        push(@hashValue2, $functionLength);

        my @specials = ();
        push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
            || $function->signature->extendedAttributes->{"NotDeletable"};
        push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
        push(@specials, "JSC::Function");
        my $special = (@specials > 0) ? join(" | ", @specials) : "0";




static const HashTableValue JSTestActiveDOMObjectPrototypeTableValues[] =
{
    { "excitingFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionExcitingFunction), (intptr_t)1 },
    { "postMessage", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionPostMessage), (intptr_t)1 },
    { 0, 0, NoIntrinsic, 0, 0 }
};


Lines 73-79 bool JSTestCustomNamedGetterConstructor: Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp -1 / +1 lines
73		73
74	static const HashTableValue JSTestCustomNamedGetterPrototypeTableValues[] =	74	static const HashTableValue JSTestCustomNamedGetterPrototypeTableValues[] =
75	{	75	{
76	{ "anotherFunction", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestCustomNamedGetterPrototypeFunctionAnotherFunction), (intptr_t)1 },	76	{ "anotherFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestCustomNamedGetterPrototypeFunctionAnotherFunction), (intptr_t)1 },
77	{ 0, 0, NoIntrinsic, 0, 0 }	77	{ 0, 0, NoIntrinsic, 0, 0 }
78	};	78	};
79		79




static const HashTableValue JSTestEventTargetPrototypeTableValues[] =
{
    { "item", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionItem), (intptr_t)1 },
    { "addEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionAddEventListener), (intptr_t)2 },
    { "removeEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionRemoveEventListener), (intptr_t)2 },
    { "dispatchEvent", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionDispatchEvent), (intptr_t)1 },
    { 0, 0, NoIntrinsic, 0, 0 }
};




    { "supplementalStaticAttr", DontDelete, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticAttr), (intptr_t)setJSTestInterfaceConstructorSupplementalStaticAttr },
#endif
#if ENABLE(Condition22) || ENABLE(Condition23)
    { "implementsMethod4", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionImplementsMethod4), (intptr_t)0 },
#endif
#if ENABLE(Condition11) || ENABLE(Condition12)
    { "supplementalMethod4", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionSupplementalMethod4), (intptr_t)0 },
#endif
    { 0, 0, NoIntrinsic, 0, 0 }
};

    { "SUPPLEMENTALCONSTANT2", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceSUPPLEMENTALCONSTANT2), (intptr_t)0 },
#endif
#if ENABLE(Condition22) || ENABLE(Condition23)
    { "implementsMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod1), (intptr_t)0 },
#endif
#if ENABLE(Condition22) || ENABLE(Condition23)
    { "implementsMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod2), (intptr_t)2 },
#endif
#if ENABLE(Condition22) || ENABLE(Condition23)
    { "implementsMethod3", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod3), (intptr_t)0 },
#endif
#if ENABLE(Condition11) || ENABLE(Condition12)
    { "supplementalMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod1), (intptr_t)0 },
#endif
#if ENABLE(Condition11) || ENABLE(Condition12)
    { "supplementalMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod2), (intptr_t)2 },
#endif
#if ENABLE(Condition11) || ENABLE(Condition12)
    { "supplementalMethod3", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod3), (intptr_t)0 },
#endif
    { 0, 0, NoIntrinsic, 0, 0 }
};

Lines 73-79 bool JSTestMediaQueryListListenerConstru Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp -1 / +1 lines
73		73
74	static const HashTableValue JSTestMediaQueryListListenerPrototypeTableValues[] =	74	static const HashTableValue JSTestMediaQueryListListenerPrototypeTableValues[] =
75	{	75	{
76	{ "method", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestMediaQueryListListenerPrototypeFunctionMethod), (intptr_t)1 },	76	{ "method", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestMediaQueryListListenerPrototypeFunctionMethod), (intptr_t)1 },
77	{ 0, 0, NoIntrinsic, 0, 0 }	77	{ 0, 0, NoIntrinsic, 0, 0 }
78	};	78	};
79		79



    { "staticReadOnlyLongAttr", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticReadOnlyLongAttr), (intptr_t)0 },
    { "staticStringAttr", DontDelete, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorStaticStringAttr), (intptr_t)setJSTestObjConstructorStaticStringAttr },
    { "TestSubObj", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjConstructorTestSubObj), (intptr_t)0 },
    { "staticMethodWithCallbackAndOptionalArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionStaticMethodWithCallbackAndOptionalArg), (intptr_t)0 },
    { "staticMethodWithCallbackArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionStaticMethodWithCallbackArg), (intptr_t)1 },
    { "classMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionClassMethod), (intptr_t)0 },
    { "classMethodWithOptional", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionClassMethodWithOptional), (intptr_t)0 },
    { "classMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionClassMethod2), (intptr_t)1 },
#if ENABLE(Condition1)
    { "overloadedMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjConstructorFunctionOverloadedMethod1), (intptr_t)1 },
#endif
    { 0, 0, NoIntrinsic, 0, 0 }
};

    { "CONST_VALUE_14", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCONST_VALUE_14), (intptr_t)0 },
    { "CONST_JAVASCRIPT", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjCONST_JAVASCRIPT), (intptr_t)0 },
    { "readonly", DontDelete | ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestObjReadonly), (intptr_t)0 },
    { "voidMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionVoidMethod), (intptr_t)0 },
    { "voidMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionVoidMethodWithArgs), (intptr_t)3 },
    { "byteMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionByteMethod), (intptr_t)0 },
    { "byteMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionByteMethodWithArgs), (intptr_t)3 },
    { "octetMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionOctetMethod), (intptr_t)0 },
    { "octetMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionOctetMethodWithArgs), (intptr_t)3 },
    { "longMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionLongMethod), (intptr_t)0 },
    { "longMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionLongMethodWithArgs), (intptr_t)3 },
    { "objMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionObjMethod), (intptr_t)0 },
    { "objMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionObjMethodWithArgs), (intptr_t)3 },
    { "methodWithSequenceArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithSequenceArg), (intptr_t)1 },
    { "methodReturningSequence", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodReturningSequence), (intptr_t)1 },
    { "methodWithEnumArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithEnumArg), (intptr_t)1 },
    { "methodThatRequiresAllArgsAndThrows", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows), (intptr_t)2 },
    { "serializedValue", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionSerializedValue), (intptr_t)1 },
    { "optionsObject", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionOptionsObject), (intptr_t)1 },
    { "methodWithException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithException), (intptr_t)0 },
    { "customMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomMethod), (intptr_t)0 },
    { "customMethodWithArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionCustomMethodWithArgs), (intptr_t)3 },
    { "addEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionAddEventListener), (intptr_t)2 },
    { "removeEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionRemoveEventListener), (intptr_t)2 },
    { "withScriptStateVoid", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptStateVoid), (intptr_t)0 },
    { "withScriptStateObj", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptStateObj), (intptr_t)0 },
    { "withScriptStateVoidException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptStateVoidException), (intptr_t)0 },
    { "withScriptStateObjException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptStateObjException), (intptr_t)0 },
    { "withScriptExecutionContext", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptExecutionContext), (intptr_t)0 },
    { "withScriptExecutionContextAndScriptState", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState), (intptr_t)0 },
    { "withScriptExecutionContextAndScriptStateObjException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException), (intptr_t)0 },
    { "withScriptExecutionContextAndScriptStateWithSpaces", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces), (intptr_t)0 },
    { "withScriptArgumentsAndCallStack", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack), (intptr_t)0 },
    { "methodWithOptionalArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithOptionalArg), (intptr_t)0 },
    { "methodWithNonOptionalArgAndOptionalArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg), (intptr_t)1 },
    { "methodWithNonOptionalArgAndTwoOptionalArgs", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs), (intptr_t)1 },
    { "methodWithOptionalString", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithOptionalString), (intptr_t)0 },
    { "methodWithOptionalStringIsUndefined", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined), (intptr_t)0 },
    { "methodWithOptionalStringIsNullString", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString), (intptr_t)0 },
    { "methodWithCallbackArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithCallbackArg), (intptr_t)1 },
    { "methodWithNonCallbackArgAndCallbackArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg), (intptr_t)2 },
    { "methodWithCallbackAndOptionalArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg), (intptr_t)0 },
#if ENABLE(Condition1)
    { "conditionalMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConditionalMethod1), (intptr_t)0 },
#endif
#if ENABLE(Condition1) && ENABLE(Condition2)
    { "conditionalMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConditionalMethod2), (intptr_t)0 },
#endif
#if ENABLE(Condition1) || ENABLE(Condition2)
    { "conditionalMethod3", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConditionalMethod3), (intptr_t)0 },
#endif
    { "overloadedMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionOverloadedMethod), (intptr_t)2 },
    { "classMethodWithClamp", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionClassMethodWithClamp), (intptr_t)2 },
    { "methodWithUnsignedLongSequence", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMethodWithUnsignedLongSequence), (intptr_t)1 },
    { "stringArrayFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionStringArrayFunction), (intptr_t)1 },
    { "domStringListFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionDomStringListFunction), (intptr_t)1 },
    { "getSVGDocument", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionGetSVGDocument), (intptr_t)0 },
    { "convert1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert1), (intptr_t)1 },
    { "convert2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert2), (intptr_t)1 },
    { "convert4", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert4), (intptr_t)1 },
    { "convert5", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionConvert5), (intptr_t)1 },
    { "mutablePointFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionMutablePointFunction), (intptr_t)0 },
    { "immutablePointFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionImmutablePointFunction), (intptr_t)0 },
    { "orange", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionOrange), (intptr_t)0 },
    { "strictFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionStrictFunction), (intptr_t)3 },
    { "strictFunctionWithSequence", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionStrictFunctionWithSequence), (intptr_t)2 },
    { "strictFunctionWithArray", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionStrictFunctionWithArray), (intptr_t)2 },
    { "variadicStringMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionVariadicStringMethod), (intptr_t)2 },
    { "variadicDoubleMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionVariadicDoubleMethod), (intptr_t)2 },
    { "variadicNodeMethod", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionVariadicNodeMethod), (intptr_t)2 },
    { "any", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestObjPrototypeFunctionAny), (intptr_t)2 },
    { 0, 0, NoIntrinsic, 0, 0 }
};





static const HashTableValue JSTestTypedefsPrototypeTableValues[] =
{
    { "func", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFunc), (intptr_t)0 },
    { "setShadow", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionSetShadow), (intptr_t)3 },
    { "methodWithSequenceArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithSequenceArg), (intptr_t)1 },
    { "nullableArrayArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionNullableArrayArg), (intptr_t)1 },
    { "funcWithClamp", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFuncWithClamp), (intptr_t)1 },
    { "immutablePointFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionImmutablePointFunction), (intptr_t)0 },
    { "stringArrayFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction), (intptr_t)1 },
    { "stringArrayFunction2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction2), (intptr_t)1 },
    { "callWithSequenceThatRequiresInclude", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude), (intptr_t)1 },
    { "methodWithException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithException), (intptr_t)0 },
    { 0, 0, NoIntrinsic, 0, 0 }
};




2013-11-11  Zan Dobersek  <zdobersek@igalia.com>

        JSC bindings generator should generate deletable JSC functions
        https://bugs.webkit.org/show_bug.cgi?id=122422

        Reviewed by Geoffrey Garen.

        Test that all the functions on the Node prototype object (apart from the constructor) are
        writable, enumerable and configurable, as expected for WebIDL operations. This matches the
        WebIDL specification as well as IE and Firefox.

        * fast/dom/webidl-operations-on-node-prototype-expected.txt: Added.
        * fast/dom/webidl-operations-on-node-prototype.html: Added.

2013-11-11  Simon Fraser  <simon.fraser@apple.com>

        Add a testcase for a tiled layer inside an iframe



Operations on the Node prototype object should be writable, enumerable and configurable.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS successfullyParsed is true

TEST COMPLETE




<html>
<head>
<script src="../../resources/js-test-pre.js"></script>
<script>
description("Operations on the Node prototype object should be writable, enumerable and configurable.");

Object.getOwnPropertyNames(Node.prototype).forEach(function(property) {
    var propertyDescriptor = Object.getOwnPropertyDescriptor(Node.prototype, property);
    if (typeof propertyDescriptor.value !== "function" || property === "constructor")
        return;

    [
        {
            name: "writable",
            test: function(property) {
                var propertyValue = Node.prototype[property];
                Node.prototype[property] = 42;
                if (Node.prototype[property] !== 42)
                    testFailed("Property " + property + " should be writable.");
                Node.prototype[property] = propertyValue;
            }
        },
        {
            name: "enumerable",
            test: function(property) {
                if (Object.keys(Node.prototype).indexOf(property) < 0)
                    testFailed("Property " + property + " should be enumerable.");
            }
        },
        {
            name: "configurable",
            test: function() {
                var propertyValue = Node.prototype[property];
                delete Node.prototype[property];
                if (Node.prototype[property] !== undefined)
                    testFailed("Property " + property  + " should be configurable.");
                Node.prototype[property] = propertyValue;
            }
        }
    ].forEach(function(attribute) {
        var propertyAttribute = "propertyDescriptor." + attribute.name;
        if (eval(propertyAttribute) !== true)
            testFailed(propertyAttribute + " for property " + property + " should be true.");
        attribute.test(property);
    });
});
</script>
<script src="../../resources/js-test-post.js"></script>
</head>
<body>
<div id="console"></div>
</body>
</html>

Return to Bug 122422

Lines 1563-1569 sub GenerateImplementation Source/WebCore/bindings/scripts/CodeGeneratorJS.pm_sec1
- Source/WebCore/bindings/scripts/CodeGeneratorJS.pm -2 / +4 lines
1563	push(@hashValue2, $functionLength);	1563	push(@hashValue2, $functionLength);
1564		1564
1565	my @specials = ();	1565	my @specials = ();
1566	push(@specials, "DontDelete") unless $function->signature->extendedAttributes->{"Deletable"};	1566	push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
		1567	\|\| $function->signature->extendedAttributes->{"NotDeletable"};
1567	push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};	1568	push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
1568	push(@specials, "JSC::Function");	1569	push(@specials, "JSC::Function");
1569	my $special = (@specials > 0) ? join(" \| ", @specials) : "0";	1570	my $special = (@specials > 0) ? join(" \| ", @specials) : "0";
Lines 1627-1633 sub GenerateImplementation Source/WebCore/bindings/scripts/CodeGeneratorJS.pm_sec2
1627	push(@hashValue2, $functionLength);	1628	push(@hashValue2, $functionLength);
1628		1629
1629	my @specials = ();	1630	my @specials = ();
1630	push(@specials, "DontDelete") unless $function->signature->extendedAttributes->{"Deletable"};	1631	push(@specials, "DontDelete") if $interface->extendedAttributes->{"OperationsNotDeletable"}
		1632	\|\| $function->signature->extendedAttributes->{"NotDeletable"};
1631	push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};	1633	push(@specials, "DontEnum") if $function->signature->extendedAttributes->{"NotEnumerable"};
1632	push(@specials, "JSC::Function");	1634	push(@specials, "JSC::Function");
1633	my $special = (@specials > 0) ? join(" \| ", @specials) : "0";	1635	my $special = (@specials > 0) ? join(" \| ", @specials) : "0";

Lines 79-88 bool JSTestEventTargetConstructor::getOw Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestEventTarget.cpp -4 / +4 lines
79		79
80	static const HashTableValue JSTestEventTargetPrototypeTableValues[] =	80	static const HashTableValue JSTestEventTargetPrototypeTableValues[] =
81	{	81	{
82	{ "item", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionItem), (intptr_t)1 },	82	{ "item", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionItem), (intptr_t)1 },
83	{ "addEventListener", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionAddEventListener), (intptr_t)2 },	83	{ "addEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionAddEventListener), (intptr_t)2 },
84	{ "removeEventListener", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionRemoveEventListener), (intptr_t)2 },	84	{ "removeEventListener", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionRemoveEventListener), (intptr_t)2 },
85	{ "dispatchEvent", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionDispatchEvent), (intptr_t)1 },	85	{ "dispatchEvent", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestEventTargetPrototypeFunctionDispatchEvent), (intptr_t)1 },
86	{ 0, 0, NoIntrinsic, 0, 0 }	86	{ 0, 0, NoIntrinsic, 0, 0 }
87	};	87	};
88		88

Lines 109-118 static const HashTableValue JSTestInterf Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp -8 / +8 lines
109	{ "supplementalStaticAttr", DontDelete, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticAttr), (intptr_t)setJSTestInterfaceConstructorSupplementalStaticAttr },	109	{ "supplementalStaticAttr", DontDelete, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceConstructorSupplementalStaticAttr), (intptr_t)setJSTestInterfaceConstructorSupplementalStaticAttr },
110	#endif	110	#endif
111	#if ENABLE(Condition22) \|\| ENABLE(Condition23)	111	#if ENABLE(Condition22) \|\| ENABLE(Condition23)
112	{ "implementsMethod4", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionImplementsMethod4), (intptr_t)0 },	112	{ "implementsMethod4", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionImplementsMethod4), (intptr_t)0 },
113	#endif	113	#endif
114	#if ENABLE(Condition11) \|\| ENABLE(Condition12)	114	#if ENABLE(Condition11) \|\| ENABLE(Condition12)
115	{ "supplementalMethod4", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionSupplementalMethod4), (intptr_t)0 },	115	{ "supplementalMethod4", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfaceConstructorFunctionSupplementalMethod4), (intptr_t)0 },
116	#endif	116	#endif
117	{ 0, 0, NoIntrinsic, 0, 0 }	117	{ 0, 0, NoIntrinsic, 0, 0 }
118	};	118	};
Lines 200-221 static const HashTableValue JSTestInterf Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp_sec2
200	{ "SUPPLEMENTALCONSTANT2", DontDelete \| ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceSUPPLEMENTALCONSTANT2), (intptr_t)0 },	200	{ "SUPPLEMENTALCONSTANT2", DontDelete \| ReadOnly, NoIntrinsic, (intptr_t)static_cast<PropertySlot::GetValueFunc>(jsTestInterfaceSUPPLEMENTALCONSTANT2), (intptr_t)0 },
201	#endif	201	#endif
202	#if ENABLE(Condition22) \|\| ENABLE(Condition23)	202	#if ENABLE(Condition22) \|\| ENABLE(Condition23)
203	{ "implementsMethod1", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod1), (intptr_t)0 },	203	{ "implementsMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod1), (intptr_t)0 },
204	#endif	204	#endif
205	#if ENABLE(Condition22) \|\| ENABLE(Condition23)	205	#if ENABLE(Condition22) \|\| ENABLE(Condition23)
206	{ "implementsMethod2", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod2), (intptr_t)2 },	206	{ "implementsMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod2), (intptr_t)2 },
207	#endif	207	#endif
208	#if ENABLE(Condition22) \|\| ENABLE(Condition23)	208	#if ENABLE(Condition22) \|\| ENABLE(Condition23)
209	{ "implementsMethod3", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod3), (intptr_t)0 },	209	{ "implementsMethod3", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionImplementsMethod3), (intptr_t)0 },
210	#endif	210	#endif
211	#if ENABLE(Condition11) \|\| ENABLE(Condition12)	211	#if ENABLE(Condition11) \|\| ENABLE(Condition12)
212	{ "supplementalMethod1", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod1), (intptr_t)0 },	212	{ "supplementalMethod1", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod1), (intptr_t)0 },
213	#endif	213	#endif
214	#if ENABLE(Condition11) \|\| ENABLE(Condition12)	214	#if ENABLE(Condition11) \|\| ENABLE(Condition12)
215	{ "supplementalMethod2", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod2), (intptr_t)2 },	215	{ "supplementalMethod2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod2), (intptr_t)2 },
216	#endif	216	#endif
217	#if ENABLE(Condition11) \|\| ENABLE(Condition12)	217	#if ENABLE(Condition11) \|\| ENABLE(Condition12)
218	{ "supplementalMethod3", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod3), (intptr_t)0 },	218	{ "supplementalMethod3", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestInterfacePrototypeFunctionSupplementalMethod3), (intptr_t)0 },
219	#endif	219	#endif
220	{ 0, 0, NoIntrinsic, 0, 0 }	220	{ 0, 0, NoIntrinsic, 0, 0 }
221	};	221	};

Lines 112-127 ConstructType JSTestTypedefsConstructor: Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp -10 / +10 lines
112		112
113	static const HashTableValue JSTestTypedefsPrototypeTableValues[] =	113	static const HashTableValue JSTestTypedefsPrototypeTableValues[] =
114	{	114	{
115	{ "func", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFunc), (intptr_t)0 },	115	{ "func", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFunc), (intptr_t)0 },
116	{ "setShadow", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionSetShadow), (intptr_t)3 },	116	{ "setShadow", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionSetShadow), (intptr_t)3 },
117	{ "methodWithSequenceArg", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithSequenceArg), (intptr_t)1 },	117	{ "methodWithSequenceArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithSequenceArg), (intptr_t)1 },
118	{ "nullableArrayArg", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionNullableArrayArg), (intptr_t)1 },	118	{ "nullableArrayArg", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionNullableArrayArg), (intptr_t)1 },
119	{ "funcWithClamp", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFuncWithClamp), (intptr_t)1 },	119	{ "funcWithClamp", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionFuncWithClamp), (intptr_t)1 },
120	{ "immutablePointFunction", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionImmutablePointFunction), (intptr_t)0 },	120	{ "immutablePointFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionImmutablePointFunction), (intptr_t)0 },
121	{ "stringArrayFunction", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction), (intptr_t)1 },	121	{ "stringArrayFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction), (intptr_t)1 },
122	{ "stringArrayFunction2", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction2), (intptr_t)1 },	122	{ "stringArrayFunction2", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionStringArrayFunction2), (intptr_t)1 },
123	{ "callWithSequenceThatRequiresInclude", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude), (intptr_t)1 },	123	{ "callWithSequenceThatRequiresInclude", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude), (intptr_t)1 },
124	{ "methodWithException", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithException), (intptr_t)0 },	124	{ "methodWithException", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestTypedefsPrototypeFunctionMethodWithException), (intptr_t)0 },
125	{ 0, 0, NoIntrinsic, 0, 0 }	125	{ 0, 0, NoIntrinsic, 0, 0 }
126	};	126	};
127		127

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +33 lines
		1	2013-11-11 Zan Dobersek <zdobersek@igalia.com>
		2
		3	JSC bindings generator should generate deletable JSC functions
		4	https://bugs.webkit.org/show_bug.cgi?id=122422
		5
		6	Reviewed by Geoffrey Garen.
		7
		8	The JSC functions that the JSC bindings generator generates should be deletable to conform to
		9	the WebIDL specification, which instructs that the WebIDL operations must be configurable (which
		10	translates to the JSC functions being deletable).
		11
		12	The generator will still produce a non-deletable JSC function for operations under almost all
		13	Web-facing interfaces since they're annotated with the OperationsNotDeletable attribute. The
		14	exception here is the Node interface that is having the attribute removed, with the provided
		15	test case testing that all the functions on the Node prototype object are writable, enumerable
		16	and configurable. This behavior conforms to the WebIDL specification and the behaviors of IE
		17	and Firefox. Chrome at the moment still provides non-configurable functions.
		18
		19	Test: fast/dom/webidl-operations-on-node-prototype.html
		20
		21	* bindings/scripts/CodeGeneratorJS.pm:
		22	(GenerateImplementation): Enforce the non-deletable behavior of the JSC function if either the
		23	operation's interface is annotated with the OperationsNotDeletable attribute or the operation itself
		24	is annotated with the NotDeletable attribute.
		25	* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Update the JSC generator test baselines.
		26	* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
		27	* bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
		28	* bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
		29	* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
		30	* bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
		31	* bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
		32	* dom/Node.idl: Remove the OperationsNotDeletable attribute.
		33
1	2013-11-11 Zan Dobersek <zdobersek@igalia.com>	34	2013-11-11 Zan Dobersek <zdobersek@igalia.com>
2		35
3	Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces	36	Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces

Lines 74-81 bool JSTestActiveDOMObjectConstructor::g Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp_sec1
- Source/WebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cpp -2 / +2 lines
74		74
75	static const HashTableValue JSTestActiveDOMObjectPrototypeTableValues[] =	75	static const HashTableValue JSTestActiveDOMObjectPrototypeTableValues[] =
76	{	76	{
77	{ "excitingFunction", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionExcitingFunction), (intptr_t)1 },	77	{ "excitingFunction", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionExcitingFunction), (intptr_t)1 },
78	{ "postMessage", DontDelete \| JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionPostMessage), (intptr_t)1 },	78	{ "postMessage", JSC::Function, NoIntrinsic, (intptr_t)static_cast<NativeFunction>(jsTestActiveDOMObjectPrototypeFunctionPostMessage), (intptr_t)1 },
79	{ 0, 0, NoIntrinsic, 0, 0 }	79	{ 0, 0, NoIntrinsic, 0, 0 }
80	};	80	};
81		81

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +14 lines
		1	2013-11-11 Zan Dobersek <zdobersek@igalia.com>
		2
		3	JSC bindings generator should generate deletable JSC functions
		4	https://bugs.webkit.org/show_bug.cgi?id=122422
		5
		6	Reviewed by Geoffrey Garen.
		7
		8	Test that all the functions on the Node prototype object (apart from the constructor) are
		9	writable, enumerable and configurable, as expected for WebIDL operations. This matches the
		10	WebIDL specification as well as IE and Firefox.
		11
		12	* fast/dom/webidl-operations-on-node-prototype-expected.txt: Added.
		13	* fast/dom/webidl-operations-on-node-prototype.html: Added.
		14
1	2013-11-11 Simon Fraser <simon.fraser@apple.com>	15	2013-11-11 Simon Fraser <simon.fraser@apple.com>
2		16
3	Add a testcase for a tiled layer inside an iframe	17	Add a testcase for a tiled layer inside an iframe

Line 0 LayoutTests/fast/dom/webidl-operations-on-node-prototype-expected.txt_sec1
- LayoutTests/fast/dom/webidl-operations-on-node-prototype-expected.txt +9 lines
	1	Operations on the Node prototype object should be writable, enumerable and configurable.
	2
	3	On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
	4
	5
	6	PASS successfullyParsed is true
	7
	8	TEST COMPLETE
	9

Line 0 LayoutTests/fast/dom/webidl-operations-on-node-prototype.html_sec1
- LayoutTests/fast/dom/webidl-operations-on-node-prototype.html +53 lines
	1	<html>
	2	<head>
	3	<script src="../../resources/js-test-pre.js"></script>
	4	<script>
	5	description("Operations on the Node prototype object should be writable, enumerable and configurable.");
	6
	7	Object.getOwnPropertyNames(Node.prototype).forEach(function(property) {
	8	var propertyDescriptor = Object.getOwnPropertyDescriptor(Node.prototype, property);
	9	if (typeof propertyDescriptor.value !== "function" \|\| property === "constructor")
	10	return;
	11
	12	[
	13	{
	14	name: "writable",
	15	test: function(property) {
	16	var propertyValue = Node.prototype[property];
	17	Node.prototype[property] = 42;
	18	if (Node.prototype[property] !== 42)
	19	testFailed("Property " + property + " should be writable.");
	20	Node.prototype[property] = propertyValue;
	21	}
	22	},
	23	{
	24	name: "enumerable",
	25	test: function(property) {
	26	if (Object.keys(Node.prototype).indexOf(property) < 0)
	27	testFailed("Property " + property + " should be enumerable.");
	28	}
	29	},
	30	{
	31	name: "configurable",
	32	test: function() {
	33	var propertyValue = Node.prototype[property];
	34	delete Node.prototype[property];
	35	if (Node.prototype[property] !== undefined)
	36	testFailed("Property " + property + " should be configurable.");
	37	Node.prototype[property] = propertyValue;
	38	}
	39	}
	40	].forEach(function(attribute) {
	41	var propertyAttribute = "propertyDescriptor." + attribute.name;
	42	if (eval(propertyAttribute) !== true)
	43	testFailed(propertyAttribute + " for property " + property + " should be true.");
	44	attribute.test(property);
	45	});
	46	});
	47	</script>
	48	<script src="../../resources/js-test-post.js"></script>
	49	</head>
	50	<body>
	51	<div id="console"></div>
	52	</body>
	53	</html>