| Differences between
and this patch
- a/Source/WebCore/ChangeLog +48 lines
Lines 1-3 a/Source/WebCore/ChangeLog_sec1
1
2013-10-04  Zan Dobersek  <zdobersek@igalia.com>
2
3
        [WebIIDL] Annotate IDL interfaces under Source/WebCore/svg/ with the OperationsNotDeletable attribute
4
        https://bugs.webkit.org/show_bug.cgi?id=122279
5
6
        Reviewed by NOBODY (OOPS!).
7
8
        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
9
        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
10
        doesn't have any effect, but will keep the operations not configurable after the generator is modified
11
        to preserve the original behavior. The attribute will be removed from each interface after checking
12
        conformity with other browsers (in terms of configurability of operations of that interface) and the
13
        WebKit's existing test suites.
14
15
        This patch covers IDL interfaces under Source/WebCore/svg/.
16
17
        * svg/SVGAngle.idl:
18
        * svg/SVGAnimationElement.idl:
19
        * svg/SVGColor.idl:
20
        * svg/SVGCursorElement.idl:
21
        * svg/SVGDocument.idl:
22
        * svg/SVGElement.idl:
23
        * svg/SVGElementInstanceList.idl:
24
        * svg/SVGException.idl:
25
        * svg/SVGFEDropShadowElement.idl:
26
        * svg/SVGFEGaussianBlurElement.idl:
27
        * svg/SVGFEMorphologyElement.idl:
28
        * svg/SVGFilterElement.idl:
29
        * svg/SVGGraphicsElement.idl:
30
        * svg/SVGLength.idl:
31
        * svg/SVGLengthList.idl:
32
        * svg/SVGMarkerElement.idl:
33
        * svg/SVGMaskElement.idl:
34
        * svg/SVGMatrix.idl:
35
        * svg/SVGNumberList.idl:
36
        * svg/SVGPaint.idl:
37
        * svg/SVGPathElement.idl:
38
        * svg/SVGPathSegList.idl:
39
        * svg/SVGPatternElement.idl:
40
        * svg/SVGPoint.idl:
41
        * svg/SVGPointList.idl:
42
        * svg/SVGSVGElement.idl:
43
        * svg/SVGStringList.idl:
44
        * svg/SVGTests.idl:
45
        * svg/SVGTextContentElement.idl:
46
        * svg/SVGTransform.idl:
47
        * svg/SVGTransformList.idl:
48
1
2013-10-03  Anders Carlsson  <andersca@apple.com>
49
2013-10-03  Anders Carlsson  <andersca@apple.com>
2
50
3
        Assert that we don't try to index past the end of the m_coreTextIndices array
51
        Assert that we don't try to index past the end of the m_coreTextIndices array
- a/Source/WebCore/svg/SVGAngle.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGAngle.idl_sec1
21
 */
21
 */
22
22
23
[
23
[
24
    Conditional=SVG
24
    Conditional=SVG,
25
    OperationsNotDeletable
25
] interface SVGAngle { 
26
] interface SVGAngle { 
26
    // Angle Unit Types
27
    // Angle Unit Types
27
    const unsigned short SVG_ANGLETYPE_UNKNOWN = 0;
28
    const unsigned short SVG_ANGLETYPE_UNKNOWN = 0;
- a/Source/WebCore/svg/SVGAnimationElement.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGAnimationElement.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGAnimationElement : SVGElement {
30
] interface SVGAnimationElement : SVGElement {
30
    readonly attribute SVGElement targetElement;
31
    readonly attribute SVGElement targetElement;
31
32
- a/Source/WebCore/svg/SVGColor.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGColor.idl_sec1
21
21
22
[
22
[
23
    Conditional=SVG,
23
    Conditional=SVG,
24
    ImplementationLacksVTable
24
    ImplementationLacksVTable,
25
    OperationsNotDeletable
25
] interface SVGColor : CSSValue {
26
] interface SVGColor : CSSValue {
26
    const unsigned short SVG_COLORTYPE_UNKNOWN = 0;
27
    const unsigned short SVG_COLORTYPE_UNKNOWN = 0;
27
    const unsigned short SVG_COLORTYPE_RGBCOLOR = 1;
28
    const unsigned short SVG_COLORTYPE_RGBCOLOR = 1;
- a/Source/WebCore/svg/SVGCursorElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGCursorElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGCursorElement : SVGElement {
29
] interface SVGCursorElement : SVGElement {
29
    readonly attribute SVGAnimatedLength x;
30
    readonly attribute SVGAnimatedLength x;
30
    readonly attribute SVGAnimatedLength y;
31
    readonly attribute SVGAnimatedLength y;
- a/Source/WebCore/svg/SVGDocument.idl -1 / +2 lines
Lines 20-26 a/Source/WebCore/svg/SVGDocument.idl_sec1
20
 */
20
 */
21
21
22
[
22
[
23
    Conditional=SVG
23
    Conditional=SVG,
24
    OperationsNotDeletable
24
] interface SVGDocument : Document {
25
] interface SVGDocument : Document {
25
    readonly attribute SVGSVGElement        rootElement;
26
    readonly attribute SVGSVGElement        rootElement;
26
27
- a/Source/WebCore/svg/SVGElement.idl -1 / +2 lines
Lines 22-28 a/Source/WebCore/svg/SVGElement.idl_sec1
22
22
23
[
23
[
24
    JSGenerateToNativeObject,
24
    JSGenerateToNativeObject,
25
    Conditional=SVG
25
    Conditional=SVG,
26
    OperationsNotDeletable
26
] interface SVGElement : Element {
27
] interface SVGElement : Element {
27
    [TreatNullAs=NullString, SetterRaisesException] attribute DOMString xmlbase;
28
    [TreatNullAs=NullString, SetterRaisesException] attribute DOMString xmlbase;
28
    readonly attribute SVGSVGElement ownerSVGElement;
29
    readonly attribute SVGSVGElement ownerSVGElement;
- a/Source/WebCore/svg/SVGElementInstanceList.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGElementInstanceList.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGElementInstanceList {
29
] interface SVGElementInstanceList {
29
    readonly attribute unsigned long length;
30
    readonly attribute unsigned long length;
30
31
- a/Source/WebCore/svg/SVGException.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGException.idl_sec1
21
[
21
[
22
    Conditional=SVG,
22
    Conditional=SVG,
23
    DoNotCheckConstants,
23
    DoNotCheckConstants,
24
    ImplementationLacksVTable
24
    ImplementationLacksVTable,
25
    OperationsNotDeletable
25
] exception SVGException {
26
] exception SVGException {
26
27
27
    readonly attribute unsigned short   code;
28
    readonly attribute unsigned short   code;
- a/Source/WebCore/svg/SVGFEDropShadowElement.idl -1 / +2 lines
Lines 18-24 a/Source/WebCore/svg/SVGFEDropShadowElement.idl_sec1
18
 */
18
 */
19
19
20
[
20
[
21
    Conditional=SVG&FILTERS
21
    Conditional=SVG&FILTERS,
22
    OperationsNotDeletable
22
] interface SVGFEDropShadowElement : SVGElement {
23
] interface SVGFEDropShadowElement : SVGElement {
23
    readonly attribute SVGAnimatedString in1;
24
    readonly attribute SVGAnimatedString in1;
24
    readonly attribute SVGAnimatedNumber dx;
25
    readonly attribute SVGAnimatedNumber dx;
- a/Source/WebCore/svg/SVGFEGaussianBlurElement.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGFEGaussianBlurElement.idl_sec1
25
25
26
[
26
[
27
    Conditional=SVG&FILTERS,
27
    Conditional=SVG&FILTERS,
28
    DoNotCheckConstants
28
    DoNotCheckConstants,
29
    OperationsNotDeletable
29
] interface SVGFEGaussianBlurElement : SVGElement {
30
] interface SVGFEGaussianBlurElement : SVGElement {
30
    // Edge Mode Values
31
    // Edge Mode Values
31
    const unsigned short SVG_EDGEMODE_UNKNOWN   = 0;
32
    const unsigned short SVG_EDGEMODE_UNKNOWN   = 0;
- a/Source/WebCore/svg/SVGFEMorphologyElement.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGFEMorphologyElement.idl_sec1
25
25
26
[
26
[
27
    Conditional=SVG&FILTERS,
27
    Conditional=SVG&FILTERS,
28
    DoNotCheckConstants
28
    DoNotCheckConstants,
29
    OperationsNotDeletable
29
] interface SVGFEMorphologyElement : SVGElement {
30
] interface SVGFEMorphologyElement : SVGElement {
30
    // Morphology Operators
31
    // Morphology Operators
31
    const unsigned short SVG_MORPHOLOGY_OPERATOR_UNKNOWN  = 0;
32
    const unsigned short SVG_MORPHOLOGY_OPERATOR_UNKNOWN  = 0;
- a/Source/WebCore/svg/SVGFilterElement.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGFilterElement.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG&FILTERS
28
    Conditional=SVG&FILTERS,
29
    OperationsNotDeletable
29
] interface SVGFilterElement : SVGElement {
30
] interface SVGFilterElement : SVGElement {
30
    readonly attribute SVGAnimatedEnumeration filterUnits;
31
    readonly attribute SVGAnimatedEnumeration filterUnits;
31
    readonly attribute SVGAnimatedEnumeration primitiveUnits;
32
    readonly attribute SVGAnimatedEnumeration primitiveUnits;
- a/Source/WebCore/svg/SVGGraphicsElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGGraphicsElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGGraphicsElement : SVGElement {
29
] interface SVGGraphicsElement : SVGElement {
29
    readonly attribute SVGAnimatedTransformList transform;
30
    readonly attribute SVGAnimatedTransformList transform;
30
31
- a/Source/WebCore/svg/SVGLength.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGLength.idl_sec1
21
 */
21
 */
22
22
23
[
23
[
24
    Conditional=SVG
24
    Conditional=SVG,
25
    OperationsNotDeletable
25
] interface SVGLength { 
26
] interface SVGLength { 
26
    // Length Unit Types
27
    // Length Unit Types
27
    const unsigned short SVG_LENGTHTYPE_UNKNOWN    = 0;
28
    const unsigned short SVG_LENGTHTYPE_UNKNOWN    = 0;
- a/Source/WebCore/svg/SVGLengthList.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGLengthList.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGLengthList { 
30
] interface SVGLengthList { 
30
    readonly attribute unsigned long numberOfItems;
31
    readonly attribute unsigned long numberOfItems;
31
32
- a/Source/WebCore/svg/SVGMarkerElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGMarkerElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGMarkerElement : SVGElement {
29
] interface SVGMarkerElement : SVGElement {
29
    // Marker Unit Types
30
    // Marker Unit Types
30
    const unsigned short SVG_MARKERUNITS_UNKNOWN        = 0;
31
    const unsigned short SVG_MARKERUNITS_UNKNOWN        = 0;
- a/Source/WebCore/svg/SVGMaskElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGMaskElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGMaskElement : SVGElement {
29
] interface SVGMaskElement : SVGElement {
29
    readonly attribute SVGAnimatedEnumeration maskUnits;
30
    readonly attribute SVGAnimatedEnumeration maskUnits;
30
    readonly attribute SVGAnimatedEnumeration maskContentUnits;
31
    readonly attribute SVGAnimatedEnumeration maskContentUnits;
- a/Source/WebCore/svg/SVGMatrix.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGMatrix.idl_sec1
21
 */
21
 */
22
22
23
[
23
[
24
    Conditional=SVG
24
    Conditional=SVG,
25
    OperationsNotDeletable
25
] interface SVGMatrix {
26
] interface SVGMatrix {
26
    // FIXME: these attributes should all be floats but since we implement
27
    // FIXME: these attributes should all be floats but since we implement
27
    // AffineTransform with doubles setting these as doubles makes more sense.
28
    // AffineTransform with doubles setting these as doubles makes more sense.
- a/Source/WebCore/svg/SVGNumberList.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGNumberList.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGNumberList {
30
] interface SVGNumberList {
30
    readonly attribute unsigned long numberOfItems;
31
    readonly attribute unsigned long numberOfItems;
31
32
- a/Source/WebCore/svg/SVGPaint.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGPaint.idl_sec1
25
25
26
[
26
[
27
    Conditional=SVG,
27
    Conditional=SVG,
28
    ImplementationLacksVTable
28
    ImplementationLacksVTable,
29
    OperationsNotDeletable
29
] interface SVGPaint : SVGColor {
30
] interface SVGPaint : SVGColor {
30
    const unsigned short SVG_PAINTTYPE_UNKNOWN = 0;
31
    const unsigned short SVG_PAINTTYPE_UNKNOWN = 0;
31
    const unsigned short SVG_PAINTTYPE_RGBCOLOR = 1;
32
    const unsigned short SVG_PAINTTYPE_RGBCOLOR = 1;
- a/Source/WebCore/svg/SVGPathElement.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGPathElement.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGPathElement : SVGGraphicsElement {
30
] interface SVGPathElement : SVGGraphicsElement {
30
    readonly attribute SVGAnimatedNumber pathLength;
31
    readonly attribute SVGAnimatedNumber pathLength;
31
32
- a/Source/WebCore/svg/SVGPathSegList.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGPathSegList.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGPathSegList {
30
] interface SVGPathSegList {
30
    readonly attribute unsigned long numberOfItems;
31
    readonly attribute unsigned long numberOfItems;
31
32
- a/Source/WebCore/svg/SVGPatternElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGPatternElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGPatternElement : SVGElement {
29
] interface SVGPatternElement : SVGElement {
29
    readonly attribute SVGAnimatedEnumeration   patternUnits;
30
    readonly attribute SVGAnimatedEnumeration   patternUnits;
30
    readonly attribute SVGAnimatedEnumeration   patternContentUnits;
31
    readonly attribute SVGAnimatedEnumeration   patternContentUnits;
- a/Source/WebCore/svg/SVGPoint.idl -1 / +2 lines
Lines 21-27 a/Source/WebCore/svg/SVGPoint.idl_sec1
21
 */
21
 */
22
22
23
[
23
[
24
    Conditional=SVG
24
    Conditional=SVG,
25
    OperationsNotDeletable
25
] interface SVGPoint {
26
] interface SVGPoint {
26
    [StrictTypeChecking] attribute float x;
27
    [StrictTypeChecking] attribute float x;
27
    [StrictTypeChecking] attribute float y;
28
    [StrictTypeChecking] attribute float y;
- a/Source/WebCore/svg/SVGPointList.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGPointList.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGPointList {
29
] interface SVGPointList {
29
    readonly attribute unsigned long numberOfItems;
30
    readonly attribute unsigned long numberOfItems;
30
31
- a/Source/WebCore/svg/SVGSVGElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGSVGElement.idl_sec1
24
// TODO: Fix SVGSVGElement inheritance (css::DocumentCSS)! 
24
// TODO: Fix SVGSVGElement inheritance (css::DocumentCSS)! 
25
// TODO: no events::DocumentEvent available!
25
// TODO: no events::DocumentEvent available!
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGSVGElement : SVGGraphicsElement {
29
] interface SVGSVGElement : SVGGraphicsElement {
29
    readonly attribute SVGAnimatedLength x;
30
    readonly attribute SVGAnimatedLength x;
30
    readonly attribute SVGAnimatedLength y;
31
    readonly attribute SVGAnimatedLength y;
- a/Source/WebCore/svg/SVGStringList.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGStringList.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGStringList {
29
] interface SVGStringList {
29
    readonly attribute unsigned long numberOfItems;
30
    readonly attribute unsigned long numberOfItems;
30
31
- a/Source/WebCore/svg/SVGTests.idl +1 lines
Lines 29-34 a/Source/WebCore/svg/SVGTests.idl_sec1
29
    Conditional=SVG,
29
    Conditional=SVG,
30
    ObjCProtocol,
30
    ObjCProtocol,
31
    SuppressToJSObject,
31
    SuppressToJSObject,
32
    OperationsNotDeletable
32
] interface SVGTests {
33
] interface SVGTests {
33
    readonly attribute SVGStringList requiredFeatures;
34
    readonly attribute SVGStringList requiredFeatures;
34
    readonly attribute SVGStringList requiredExtensions;
35
    readonly attribute SVGStringList requiredExtensions;
- a/Source/WebCore/svg/SVGTextContentElement.idl -1 / +2 lines
Lines 24-30 a/Source/WebCore/svg/SVGTextContentElement.idl_sec1
24
 */
24
 */
25
25
26
[
26
[
27
    Conditional=SVG
27
    Conditional=SVG,
28
    OperationsNotDeletable
28
] interface SVGTextContentElement : SVGGraphicsElement {
29
] interface SVGTextContentElement : SVGGraphicsElement {
29
    // lengthAdjust Types
30
    // lengthAdjust Types
30
    const unsigned short LENGTHADJUST_UNKNOWN          = 0;
31
    const unsigned short LENGTHADJUST_UNKNOWN          = 0;
- a/Source/WebCore/svg/SVGTransform.idl -1 / +2 lines
Lines 20-26 a/Source/WebCore/svg/SVGTransform.idl_sec1
20
 */
20
 */
21
21
22
[
22
[
23
    Conditional=SVG
23
    Conditional=SVG,
24
    OperationsNotDeletable
24
] interface SVGTransform { 
25
] interface SVGTransform { 
25
    // Transform Types
26
    // Transform Types
26
    const unsigned short SVG_TRANSFORM_UNKNOWN = 0;
27
    const unsigned short SVG_TRANSFORM_UNKNOWN = 0;
- a/Source/WebCore/svg/SVGTransformList.idl -1 / +2 lines
Lines 25-31 a/Source/WebCore/svg/SVGTransformList.idl_sec1
25
 */
25
 */
26
26
27
[
27
[
28
    Conditional=SVG
28
    Conditional=SVG,
29
    OperationsNotDeletable
29
] interface SVGTransformList {
30
] interface SVGTransformList {
30
    readonly attribute unsigned long numberOfItems;
31
    readonly attribute unsigned long numberOfItems;
31
32

Return to Bug 122279