Attachment #213350 for bug #122275

View Details Raw Unified Return to Bug 122275

| Differences between



2013-10-04  Zan Dobersek  <zdobersek@igalia.com>

        [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
        https://bugs.webkit.org/show_bug.cgi?id=122275

        Reviewed by Darin Adler.

        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
        doesn't have any effect, but will keep the operations not configurable after the generator is modified
        to preserve the original behavior. The attribute will be removed from each interface after checking
        conformity with other browsers (in terms of configurability of operations of that interface) and the
        WebKit's existing test suites.

        This patch covers IDL interfaces under Source/WebCore/fileapi/.

        * fileapi/Blob.idl:
        * fileapi/FileException.idl:
        * fileapi/FileList.idl:
        * fileapi/FileReader.idl:
        * fileapi/FileReaderSync.idl:

2013-10-03  Anders Carlsson  <andersca@apple.com>

        Assert that we don't try to index past the end of the m_coreTextIndices array



    CustomToJSObject,
    JSNoStaticTables,
    CustomConstructor,
    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
    OperationsNotDeletable
] interface Blob {
    readonly attribute unsigned long long size;
    readonly attribute DOMString type;



    Conditional=BLOB,
    DoNotCheckConstants,
    JSNoStaticTables,
    ImplementationLacksVTable,
    OperationsNotDeletable
] exception FileException {

    readonly attribute unsigned short   code;




[
    JSNoStaticTables,
    ImplementationLacksVTable,
    OperationsNotDeletable
] interface FileList {
    readonly attribute unsigned long length;
    getter File item(unsigned long index);



    Constructor,
    ConstructorCallWith=ScriptExecutionContext,
    EventTarget,
    JSNoStaticTables,
    OperationsNotDeletable
] interface FileReader {
    // ready states
    const unsigned short EMPTY = 0;



    GlobalContext=WorkerGlobalScope,
    Conditional=BLOB,
    Constructor,
    JSNoStaticTables,
    OperationsNotDeletable
] interface FileReaderSync {
    [CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
    [CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);

Return to Bug 122275

Lines 25-31 a/Source/WebCore/fileapi/FileList.idl_sec1
- a/Source/WebCore/fileapi/FileList.idl -1 / +2 lines
25		25
26	[	26	[
27	JSNoStaticTables,	27	JSNoStaticTables,
28	ImplementationLacksVTable	28	ImplementationLacksVTable,
		29	OperationsNotDeletable
29	] interface FileList {	30	] interface FileList {
30	readonly attribute unsigned long length;	31	readonly attribute unsigned long length;
31	getter File item(unsigned long index);	32	getter File item(unsigned long index);

Lines 36-42 a/Source/WebCore/fileapi/FileReader.idl_sec1
- a/Source/WebCore/fileapi/FileReader.idl -1 / +2 lines
36	Constructor,	36	Constructor,
37	ConstructorCallWith=ScriptExecutionContext,	37	ConstructorCallWith=ScriptExecutionContext,
38	EventTarget,	38	EventTarget,
39	JSNoStaticTables	39	JSNoStaticTables,
		40	OperationsNotDeletable
40	] interface FileReader {	41	] interface FileReader {
41	// ready states	42	// ready states
42	const unsigned short EMPTY = 0;	43	const unsigned short EMPTY = 0;

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +22 lines
		1	2013-10-04 Zan Dobersek <zdobersek@igalia.com>
		2
		3	[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
		4	https://bugs.webkit.org/show_bug.cgi?id=122275
		5
		6	Reviewed by Darin Adler.
		7
		8	Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
		9	interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
		10	doesn't have any effect, but will keep the operations not configurable after the generator is modified
		11	to preserve the original behavior. The attribute will be removed from each interface after checking
		12	conformity with other browsers (in terms of configurability of operations of that interface) and the
		13	WebKit's existing test suites.
		14
		15	This patch covers IDL interfaces under Source/WebCore/fileapi/.
		16
		17	* fileapi/Blob.idl:
		18	* fileapi/FileException.idl:
		19	* fileapi/FileList.idl:
		20	* fileapi/FileReader.idl:
		21	* fileapi/FileReaderSync.idl:
		22
1	2013-10-03 Anders Carlsson <andersca@apple.com>	23	2013-10-03 Anders Carlsson <andersca@apple.com>
2		24
3	Assert that we don't try to index past the end of the m_coreTextIndices array	25	Assert that we don't try to index past the end of the m_coreTextIndices array

Lines 34-40 a/Source/WebCore/fileapi/Blob.idl_sec1
- a/Source/WebCore/fileapi/Blob.idl -1 / +2 lines
34	CustomToJSObject,	34	CustomToJSObject,
35	JSNoStaticTables,	35	JSNoStaticTables,
36	CustomConstructor,	36	CustomConstructor,
37	CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)	37	CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
		38	OperationsNotDeletable
38	] interface Blob {	39	] interface Blob {
39	readonly attribute unsigned long long size;	40	readonly attribute unsigned long long size;
40	readonly attribute DOMString type;	41	readonly attribute DOMString type;

Lines 33-39 a/Source/WebCore/fileapi/FileException.idl_sec1
- a/Source/WebCore/fileapi/FileException.idl -1 / +2 lines
33	Conditional=BLOB,	33	Conditional=BLOB,
34	DoNotCheckConstants,	34	DoNotCheckConstants,
35	JSNoStaticTables,	35	JSNoStaticTables,
36	ImplementationLacksVTable	36	ImplementationLacksVTable,
		37	OperationsNotDeletable
37	] exception FileException {	38	] exception FileException {
38		39
39	readonly attribute unsigned short code;	40	readonly attribute unsigned short code;

Lines 32-38 a/Source/WebCore/fileapi/FileReaderSync.idl_sec1
- a/Source/WebCore/fileapi/FileReaderSync.idl -1 / +2 lines
32	GlobalContext=WorkerGlobalScope,	32	GlobalContext=WorkerGlobalScope,
33	Conditional=BLOB,	33	Conditional=BLOB,
34	Constructor,	34	Constructor,
35	JSNoStaticTables	35	JSNoStaticTables,
		36	OperationsNotDeletable
36	] interface FileReaderSync {	37	] interface FileReaderSync {
37	[CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);	38	[CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
38	[CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);	39	[CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);