Attachment #213258 for bug #122275

View Details Raw Unified Return to Bug 122275

| Differences between



2013-10-03  Zan Dobersek  <zdobersek@igalia.com>

        [WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
        https://bugs.webkit.org/show_bug.cgi?id=122275

        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
        doesn't have any effect, but will keep the operations not configurable after the generator is modified
        to preserve the original behavior. The attribute will be removed from each interface after checking
        conformity with other browsers (in terms of configurability of operations of that interface) and the
        WebKit's existing test suites.

        This patch covers IDL interfaces under Source/WebCore/fileapi/.

        * fileapi/Blob.idl:
        * fileapi/File.idl:
        * fileapi/FileError.idl:
        * fileapi/FileList.idl:
        * fileapi/FileReader.idl:
        * fileapi/FileReaderSync.idl:

2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Expose aria-invalid as a text attribute (not object attribute)



    CustomToJSObject,
    JSNoStaticTables,
    CustomConstructor,
    CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
    OperationsNotDeletable
] interface Blob {
    readonly attribute unsigned long long size;
    readonly attribute DOMString type;



[
    JSGenerateToNativeObject,
    JSGenerateToJSObject,
    JSNoStaticTables,
    OperationsNotDeletable
] interface File : Blob {
    readonly attribute DOMString name;
#if !defined(LANGUAGE_GOBJECT) || !LANGUAGE_GOBJECT



[
    Conditional=BLOB,
    JSNoStaticTables,
    ImplementationLacksVTable,
    OperationsNotDeletable
] interface FileError {
#if !defined(LANGUAGE_OBJECTIVE_C)
    // FIXME: Some of constant names are already defined in DOMException.h for Objective-C binding and we cannot have the same names here (they are translated into a enum in the same namespace).




[
    JSNoStaticTables,
    ImplementationLacksVTable,
    OperationsNotDeletable
] interface FileList {
    readonly attribute unsigned long length;
    getter File item(unsigned long index);



    Constructor,
    ConstructorCallWith=ScriptExecutionContext,
    EventTarget,
    JSNoStaticTables,
    OperationsNotDeletable
] interface FileReader {
    // ready states
    const unsigned short EMPTY = 0;



    GlobalContext=WorkerGlobalScope,
    Conditional=BLOB,
    Constructor,
    JSNoStaticTables,
    OperationsNotDeletable
] interface FileReaderSync {
    [CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
    [CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);

Return to Bug 122275

Lines 34-40 a/Source/WebCore/fileapi/Blob.idl_sec1
- a/Source/WebCore/fileapi/Blob.idl -1 / +2 lines
34	CustomToJSObject,	34	CustomToJSObject,
35	JSNoStaticTables,	35	JSNoStaticTables,
36	CustomConstructor,	36	CustomConstructor,
37	CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options)	37	CustomConstructor(sequence<any> blobParts, optional BlobPropertyBag options),
		38	OperationsNotDeletable
38	] interface Blob {	39	] interface Blob {
39	readonly attribute unsigned long long size;	40	readonly attribute unsigned long long size;
40	readonly attribute DOMString type;	41	readonly attribute DOMString type;

Lines 36-42 a/Source/WebCore/fileapi/FileReader.idl_sec1
- a/Source/WebCore/fileapi/FileReader.idl -1 / +2 lines
36	Constructor,	36	Constructor,
37	ConstructorCallWith=ScriptExecutionContext,	37	ConstructorCallWith=ScriptExecutionContext,
38	EventTarget,	38	EventTarget,
39	JSNoStaticTables	39	JSNoStaticTables,
		40	OperationsNotDeletable
40	] interface FileReader {	41	] interface FileReader {
41	// ready states	42	// ready states
42	const unsigned short EMPTY = 0;	43	const unsigned short EMPTY = 0;

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +21 lines
		1	2013-10-03 Zan Dobersek <zdobersek@igalia.com>
		2
		3	[WebIDL] Annotate IDL interfaces under Source/WebCore/fileapi/ with the OperationsNotDeletable attribute
		4	https://bugs.webkit.org/show_bug.cgi?id=122275
		5
		6	Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
		7	interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
		8	doesn't have any effect, but will keep the operations not configurable after the generator is modified
		9	to preserve the original behavior. The attribute will be removed from each interface after checking
		10	conformity with other browsers (in terms of configurability of operations of that interface) and the
		11	WebKit's existing test suites.
		12
		13	This patch covers IDL interfaces under Source/WebCore/fileapi/.
		14
		15	* fileapi/Blob.idl:
		16	* fileapi/File.idl:
		17	* fileapi/FileError.idl:
		18	* fileapi/FileList.idl:
		19	* fileapi/FileReader.idl:
		20	* fileapi/FileReaderSync.idl:
		21
1	2013-10-02 Mario Sanchez Prada <mario.prada@samsung.com>	22	2013-10-02 Mario Sanchez Prada <mario.prada@samsung.com>
2		23
3	[ATK] Expose aria-invalid as a text attribute (not object attribute)	24	[ATK] Expose aria-invalid as a text attribute (not object attribute)

Lines 26-32 a/Source/WebCore/fileapi/File.idl_sec1
- a/Source/WebCore/fileapi/File.idl -1 / +2 lines
26	[	26	[
27	JSGenerateToNativeObject,	27	JSGenerateToNativeObject,
28	JSGenerateToJSObject,	28	JSGenerateToJSObject,
29	JSNoStaticTables	29	JSNoStaticTables,
		30	OperationsNotDeletable
30	] interface File : Blob {	31	] interface File : Blob {
31	readonly attribute DOMString name;	32	readonly attribute DOMString name;
32	#if !defined(LANGUAGE_GOBJECT) \|\| !LANGUAGE_GOBJECT	33	#if !defined(LANGUAGE_GOBJECT) \|\| !LANGUAGE_GOBJECT

Lines 31-37 a/Source/WebCore/fileapi/FileError.idl_sec1
- a/Source/WebCore/fileapi/FileError.idl -1 / +2 lines
31	[	31	[
32	Conditional=BLOB,	32	Conditional=BLOB,
33	JSNoStaticTables,	33	JSNoStaticTables,
34	ImplementationLacksVTable	34	ImplementationLacksVTable,
		35	OperationsNotDeletable
35	] interface FileError {	36	] interface FileError {
36	#if !defined(LANGUAGE_OBJECTIVE_C)	37	#if !defined(LANGUAGE_OBJECTIVE_C)
37	// FIXME: Some of constant names are already defined in DOMException.h for Objective-C binding and we cannot have the same names here (they are translated into a enum in the same namespace).	38	// FIXME: Some of constant names are already defined in DOMException.h for Objective-C binding and we cannot have the same names here (they are translated into a enum in the same namespace).

Lines 25-31 a/Source/WebCore/fileapi/FileList.idl_sec1
- a/Source/WebCore/fileapi/FileList.idl -1 / +2 lines
25		25
26	[	26	[
27	JSNoStaticTables,	27	JSNoStaticTables,
28	ImplementationLacksVTable	28	ImplementationLacksVTable,
		29	OperationsNotDeletable
29	] interface FileList {	30	] interface FileList {
30	readonly attribute unsigned long length;	31	readonly attribute unsigned long length;
31	getter File item(unsigned long index);	32	getter File item(unsigned long index);

Lines 32-38 a/Source/WebCore/fileapi/FileReaderSync.idl_sec1
- a/Source/WebCore/fileapi/FileReaderSync.idl -1 / +2 lines
32	GlobalContext=WorkerGlobalScope,	32	GlobalContext=WorkerGlobalScope,
33	Conditional=BLOB,	33	Conditional=BLOB,
34	Constructor,	34	Constructor,
35	JSNoStaticTables	35	JSNoStaticTables,
		36	OperationsNotDeletable
36	] interface FileReaderSync {	37	] interface FileReaderSync {
37	[CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);	38	[CallWith=ScriptExecutionContext, RaisesException] ArrayBuffer readAsArrayBuffer(Blob blob);
38	[CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);	39	[CallWith=ScriptExecutionContext, RaisesException] DOMString readAsBinaryString(Blob blob);