Attachment #213253 for bug #122270

View Details Raw Unified Return to Bug 122270



2013-10-03  Zan Dobersek  <zdobersek@igalia.com>

        [WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
        https://bugs.webkit.org/show_bug.cgi?id=122270

        Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
        interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
        doesn't have any effect, but will keep the operations not configurable after the generator is modified
        to preserve the original behavior. The attribute will be removed from each interface after checking
        conformity with other browsers (in terms of configurability of operations of that interface) and the
        WebKit's existing test suites.

        This patch covers IDL interfaces under Source/WebCore/workers/.

        * workers/AbstractWorker.idl:
        * workers/DedicatedWorkerGlobalScope.idl:
        * workers/SharedWorker.idl:
        * workers/SharedWorkerGlobalScope.idl:
        * workers/Worker.idl:
        * workers/WorkerGlobalScope.idl:
        * workers/WorkerLocation.idl:

2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>

        [ATK] Expose aria-invalid as a text attribute (not object attribute)

Lines 32-37 a/Source/WebCore/workers/AbstractWorker.idl_sec1
- a/Source/WebCore/workers/AbstractWorker.idl +1 lines
32	[	32	[
33	NoInterfaceObject,	33	NoInterfaceObject,
34	Conditional=WORKERS,	34	Conditional=WORKERS,
		35	OperationsNotDeletable
35	] interface AbstractWorker {	36	] interface AbstractWorker {
36	attribute EventListener onerror;	37	attribute EventListener onerror;
37	};	38	};

Lines 33-38 a/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl_sec1
- a/Source/WebCore/workers/DedicatedWorkerGlobalScope.idl +1 lines
33	Conditional=WORKERS,	33	Conditional=WORKERS,
34	JSGenerateToNativeObject,	34	JSGenerateToNativeObject,
35	JSNoStaticTables,	35	JSNoStaticTables,
		36	OperationsNotDeletable
36	] interface DedicatedWorkerGlobalScope : WorkerGlobalScope {	37	] interface DedicatedWorkerGlobalScope : WorkerGlobalScope {
37		38
38	#if !defined(LANGUAGE_CPP) \|\| !LANGUAGE_CPP	39	#if !defined(LANGUAGE_CPP) \|\| !LANGUAGE_CPP



    JSCustomMarkFunction,
    JSGenerateToNativeObject,
    JSGenerateToJSObject,
    ActiveDOMObject,
    OperationsNotDeletable
] interface SharedWorker : EventTarget {
    readonly attribute MessagePort port;
};

Lines 33-38 a/Source/WebCore/workers/SharedWorkerGlobalScope.idl_sec1
- a/Source/WebCore/workers/SharedWorkerGlobalScope.idl +1 lines
33	Conditional=SHARED_WORKERS,	33	Conditional=SHARED_WORKERS,
34	JSGenerateToNativeObject,	34	JSGenerateToNativeObject,
35	JSNoStaticTables,	35	JSNoStaticTables,
		36	OperationsNotDeletable
36	] interface SharedWorkerGlobalScope : WorkerGlobalScope {	37	] interface SharedWorkerGlobalScope : WorkerGlobalScope {
37		38
38	readonly attribute DOMString name;	39	readonly attribute DOMString name;



    CustomConstructor(DOMString scriptUrl),
    JSGenerateToNativeObject,
    JSGenerateToJSObject,
    ActiveDOMObject,
    OperationsNotDeletable
] interface Worker : EventTarget {

    attribute EventListener onmessage;

Lines 32-37 a/Source/WebCore/workers/WorkerGlobalScope.idl_sec1
- a/Source/WebCore/workers/WorkerGlobalScope.idl +1 lines
32	EventTarget,	32	EventTarget,
33	JSLegacyParent=JSWorkerGlobalScopeBase,	33	JSLegacyParent=JSWorkerGlobalScopeBase,
34	JSNoStaticTables,	34	JSNoStaticTables,
		35	OperationsNotDeletable
35	] interface WorkerGlobalScope {	36	] interface WorkerGlobalScope {
36		37
37	// WorkerGlobalScope	38	// WorkerGlobalScope



    Conditional=WORKERS,
    GenerateIsReachable=Impl,
    JSNoStaticTables,
    ImplementationLacksVTable,
    OperationsNotDeletable
] interface WorkerLocation {
    readonly attribute DOMString href;
    readonly attribute DOMString protocol;

Return to Bug 122270

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +22 lines
		1	2013-10-03 Zan Dobersek <zdobersek@igalia.com>
		2
		3	[WebIDL] Annotate IDL interfaces under Source/WebCore/workers/ with the OperationsNotDeletable attribute
		4	https://bugs.webkit.org/show_bug.cgi?id=122270
		5
		6	Before changing the JSC bindings generator to enforce WebIDL operations to be configurable, all the
		7	interfaces are being annotated with the OperationsNotDeletable attribute. The attribute currently
		8	doesn't have any effect, but will keep the operations not configurable after the generator is modified
		9	to preserve the original behavior. The attribute will be removed from each interface after checking
		10	conformity with other browsers (in terms of configurability of operations of that interface) and the
		11	WebKit's existing test suites.
		12
		13	This patch covers IDL interfaces under Source/WebCore/workers/.
		14
		15	* workers/AbstractWorker.idl:
		16	* workers/DedicatedWorkerGlobalScope.idl:
		17	* workers/SharedWorker.idl:
		18	* workers/SharedWorkerGlobalScope.idl:
		19	* workers/Worker.idl:
		20	* workers/WorkerGlobalScope.idl:
		21	* workers/WorkerLocation.idl:
		22
1	2013-10-02 Mario Sanchez Prada <mario.prada@samsung.com>	23	2013-10-02 Mario Sanchez Prada <mario.prada@samsung.com>
2		24
3	[ATK] Expose aria-invalid as a text attribute (not object attribute)	25	[ATK] Expose aria-invalid as a text attribute (not object attribute)

Lines 36-42 a/Source/WebCore/workers/SharedWorker.idl_sec1
- a/Source/WebCore/workers/SharedWorker.idl -1 / +2 lines
36	JSCustomMarkFunction,	36	JSCustomMarkFunction,
37	JSGenerateToNativeObject,	37	JSGenerateToNativeObject,
38	JSGenerateToJSObject,	38	JSGenerateToJSObject,
39	ActiveDOMObject	39	ActiveDOMObject,
		40	OperationsNotDeletable
40	] interface SharedWorker : EventTarget {	41	] interface SharedWorker : EventTarget {
41	readonly attribute MessagePort port;	42	readonly attribute MessagePort port;
42	};	43	};

Lines 30-36 a/Source/WebCore/workers/Worker.idl_sec1
- a/Source/WebCore/workers/Worker.idl -1 / +2 lines
30	CustomConstructor(DOMString scriptUrl),	30	CustomConstructor(DOMString scriptUrl),
31	JSGenerateToNativeObject,	31	JSGenerateToNativeObject,
32	JSGenerateToJSObject,	32	JSGenerateToJSObject,
33	ActiveDOMObject	33	ActiveDOMObject,
		34	OperationsNotDeletable
34	] interface Worker : EventTarget {	35	] interface Worker : EventTarget {
35		36
36	attribute EventListener onmessage;	37	attribute EventListener onmessage;

Lines 31-37 a/Source/WebCore/workers/WorkerLocation.idl_sec1
- a/Source/WebCore/workers/WorkerLocation.idl -1 / +2 lines
31	Conditional=WORKERS,	31	Conditional=WORKERS,
32	GenerateIsReachable=Impl,	32	GenerateIsReachable=Impl,
33	JSNoStaticTables,	33	JSNoStaticTables,
34	ImplementationLacksVTable	34	ImplementationLacksVTable,
		35	OperationsNotDeletable
35	] interface WorkerLocation {	36	] interface WorkerLocation {
36	readonly attribute DOMString href;	37	readonly attribute DOMString href;
37	readonly attribute DOMString protocol;	38	readonly attribute DOMString protocol;