Attachment #210131 for bug #120539

View Details Raw Unified Return to Bug 120539



2013-08-30  Commit Queue  <commit-queue@webkit.org>

        Unreviewed, rolling out r154891.
        http://trac.webkit.org/changeset/154891
        https://bugs.webkit.org/show_bug.cgi?id=120539

        broke the mac build (Requested by Ossy on #webkit).

        * platform/network/SynchronousLoaderClient.h:

2013-08-30  Csaba Osztrogonác  <ossy@webkit.org>

        Add USE(CFNETWORK) guard to SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge()




    virtual void willSendRequest(ResourceHandle*, ResourceRequest&, const ResourceResponse& /*redirectResponse*/) OVERRIDE;
    virtual bool shouldUseCredentialStorage(ResourceHandle*) OVERRIDE;
#if USE(CFNETWORK)
    virtual void didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge&) OVERRIDE;
#endif
    virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&) OVERRIDE;
    virtual void didReceiveData(ResourceHandle*, const char*, int, int /*encodedDataLength*/) OVERRIDE;
    virtual void didFinishLoading(ResourceHandle*, double /*finishTime*/) OVERRIDE;

Return to Bug 120539

Lines 58-66 private: a/Source/WebCore/platform/network/SynchronousLoaderClient.h_sec1
- a/Source/WebCore/platform/network/SynchronousLoaderClient.h -2 lines
58		58
59	virtual void willSendRequest(ResourceHandle, ResourceRequest&, const ResourceResponse& /redirectResponse*/) OVERRIDE;	59	virtual void willSendRequest(ResourceHandle, ResourceRequest&, const ResourceResponse& /redirectResponse*/) OVERRIDE;
60	virtual bool shouldUseCredentialStorage(ResourceHandle*) OVERRIDE;	60	virtual bool shouldUseCredentialStorage(ResourceHandle*) OVERRIDE;
61	#if USE(CFNETWORK)
62	virtual void didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge&) OVERRIDE;	61	virtual void didReceiveAuthenticationChallenge(ResourceHandle*, const AuthenticationChallenge&) OVERRIDE;
63	#endif
64	virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&) OVERRIDE;	62	virtual void didReceiveResponse(ResourceHandle*, const ResourceResponse&) OVERRIDE;
65	virtual void didReceiveData(ResourceHandle, const char, int, int /encodedDataLength/) OVERRIDE;	63	virtual void didReceiveData(ResourceHandle, const char, int, int /encodedDataLength/) OVERRIDE;
66	virtual void didFinishLoading(ResourceHandle, double /finishTime*/) OVERRIDE;	64	virtual void didFinishLoading(ResourceHandle, double /finishTime*/) OVERRIDE;

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +10 lines
		1	2013-08-30 Commit Queue <commit-queue@webkit.org>
		2
		3	Unreviewed, rolling out r154891.
		4	http://trac.webkit.org/changeset/154891
		5	https://bugs.webkit.org/show_bug.cgi?id=120539
		6
		7	broke the mac build (Requested by Ossy on #webkit).
		8
		9	* platform/network/SynchronousLoaderClient.h:
		10
1	2013-08-30 Csaba Osztrogonác <ossy@webkit.org>	11	2013-08-30 Csaba Osztrogonác <ossy@webkit.org>
2		12
3	Add USE(CFNETWORK) guard to SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge()	13	Add USE(CFNETWORK) guard to SynchronousLoaderClient::didReceiveAuthenticationChallengedidReceiveAuthenticationChallenge()