Attachment #205057 for bug #117820

View Details Raw Unified Return to Bug 117820



2013-06-19  Christophe Dumez  <ch.dumez@sisa.samsung.com>

        The order of the generated supplemental code is not guaranteed
        https://bugs.webkit.org/show_bug.cgi?id=117820

        Reviewed by NOBODY (OOPS!).

        Sort the supplemental idl files before generating the code so that it is
        generated in a consistent order.

        No new tests, covered by existing bindings tests.

        * bindings/scripts/generate-bindings.pl:

2013-06-19  Alexey Proskuryakov  <ap@apple.com>

        [Mac] Common crashes when playing media

Lines 100-106 if ($supplementalDependencyFile) { a/Source/WebCore/bindings/scripts/generate-bindings.pl_sec1
- a/Source/WebCore/bindings/scripts/generate-bindings.pl -1 / +1 lines
100	my ($idlFile, @followingIdlFiles) = split(/\s+/, $line);	100	my ($idlFile, @followingIdlFiles) = split(/\s+/, $line);
101	if ($idlFile and basename($idlFile) eq basename($targetIdlFile)) {	101	if ($idlFile and basename($idlFile) eq basename($targetIdlFile)) {
102	$idlFound = 1;	102	$idlFound = 1;
103	@supplementedIdlFiles = @followingIdlFiles;	103	@supplementedIdlFiles = sort @followingIdlFiles;
104	}	104	}
105	}	105	}
106	close FH;	106	close FH;

Return to Bug 117820

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +14 lines
		1	2013-06-19 Christophe Dumez <ch.dumez@sisa.samsung.com>
		2
		3	The order of the generated supplemental code is not guaranteed
		4	https://bugs.webkit.org/show_bug.cgi?id=117820
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Sort the supplemental idl files before generating the code so that it is
		9	generated in a consistent order.
		10
		11	No new tests, covered by existing bindings tests.
		12
		13	* bindings/scripts/generate-bindings.pl:
		14
1	2013-06-19 Alexey Proskuryakov <ap@apple.com>	15	2013-06-19 Alexey Proskuryakov <ap@apple.com>
2		16
3	[Mac] Common crashes when playing media	17	[Mac] Common crashes when playing media