Attachment #186655 for bug #108956

View Details Raw Unified Return to Bug 108956



2013-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r141896.
        http://trac.webkit.org/changeset/141896
        https://bugs.webkit.org/show_bug.cgi?id=108956

        crashes indexdb security tests (Requested by gavinp on
        #webkit).

        * public/platform/WebKitPlatformSupport.h:
        (WebKit):
        (WebKitPlatformSupport):
        (WebKit::WebKitPlatformSupport::idbFactory):
        * src/IDBFactoryBackendProxy.cpp:
        (WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

2013-02-05  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Remove idbFactory from WebKitPlatformSupport

Lines 35-41 a/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h_sec1
- a/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h +8 lines
35		35
36	namespace WebKit {	36	namespace WebKit {
37		37
		38	class WebIDBFactory; // FIXME: Does this belong in platform?
		39
		40	// FIXME: Eventually all these API will need to move to WebKit::Platform.
38	class WebKitPlatformSupport : public Platform {	41	class WebKitPlatformSupport : public Platform {
		42	public:
		43	// Indexed Database ----------------------------------------------------
		44
		45	virtual WebIDBFactory* idbFactory() { return 0; }
		46
39	protected:	47	protected:
40	~WebKitPlatformSupport() { }	48	~WebKitPlatformSupport() { }
41	};	49	};

Lines 53-58 a/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp_sec1
- a/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp -2 / +5 lines
53	#include "WorkerLoaderProxy.h"	53	#include "WorkerLoaderProxy.h"
54	#include "WorkerScriptController.h"	54	#include "WorkerScriptController.h"
55	#include "WorkerThread.h"	55	#include "WorkerThread.h"
		56	#include "platform/WebKitPlatformSupport.h"
56	#include <public/WebVector.h>	57	#include <public/WebVector.h>
57		58
58		59
Lines 74-81 PassRefPtr<IDBFactoryBackendInterface> IDBFactoryBackendProxy::create() a/Source/WebKit/chromium/src/IDBFactoryBackendProxy.cpp_sec2
74		75
75	IDBFactoryBackendProxy::IDBFactoryBackendProxy()	76	IDBFactoryBackendProxy::IDBFactoryBackendProxy()
76	{	77	{
77	ASSERT(s_webIDBFactory);	78	if (s_webIDBFactory)
78	m_webIDBFactory = s_webIDBFactory;	79	m_webIDBFactory = s_webIDBFactory;
		80	else
		81	m_webIDBFactory = webKitPlatformSupport()->idbFactory();
79	}	82	}
80		83
81	IDBFactoryBackendProxy::~IDBFactoryBackendProxy()	84	IDBFactoryBackendProxy::~IDBFactoryBackendProxy()

Return to Bug 108956

Lines 1-3 a/Source/WebKit/chromium/ChangeLog_sec1
- a/Source/WebKit/chromium/ChangeLog +16 lines
		1	2013-02-05 Sheriff Bot <webkit.review.bot@gmail.com>
		2
		3	Unreviewed, rolling out r141896.
		4	http://trac.webkit.org/changeset/141896
		5	https://bugs.webkit.org/show_bug.cgi?id=108956
		6
		7	crashes indexdb security tests (Requested by gavinp on
		8	#webkit).
		9
		10	* public/platform/WebKitPlatformSupport.h:
		11	(WebKit):
		12	(WebKitPlatformSupport):
		13	(WebKit::WebKitPlatformSupport::idbFactory):
		14	* src/IDBFactoryBackendProxy.cpp:
		15	(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):
		16
1	2013-02-05 Mark Pilgrim <pilgrim@chromium.org>	17	2013-02-05 Mark Pilgrim <pilgrim@chromium.org>
2		18
3	[Chromium] Remove idbFactory from WebKitPlatformSupport	19	[Chromium] Remove idbFactory from WebKitPlatformSupport