Attachment #181686 for bug #106321

View Details Raw Unified Return to Bug 106321



2013-01-08  Thiago Marcos P. Santos  <thiago.santos@intel.com>

        CoreIPC: Uninitialized data warnings when running on valgrind
        https://bugs.webkit.org/show_bug.cgi?id=106321

        Reviewed by NOBODY (OOPS!).

        The contents of the inline buffer is being sent uninitialized
        when the size of the message is smaller than the buffer size.
        This is not exactly a problem but is an annoyance when debugging
        memory errors. memset()'ing on Debug builds hides the warnings.

        * Platform/CoreIPC/ArgumentEncoder.cpp:
        (CoreIPC::ArgumentEncoder::ArgumentEncoder):

2013-01-07  Christophe Dumez  <christophe.dumez@intel.com>

        [CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing

Lines 42-47 ArgumentEncoder::ArgumentEncoder() a/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp_sec1
- a/Source/WebKit2/Platform/CoreIPC/ArgumentEncoder.cpp +3 lines
42	, m_bufferSize(0)	42	, m_bufferSize(0)
43	, m_bufferCapacity(inlineBufferSize)	43	, m_bufferCapacity(inlineBufferSize)
44	{	44	{
		45	#ifndef NDEBUG
		46	memset(m_inlineBuffer, 0, inlineBufferSize);
		47	#endif
45	}	48	}
46		49
47	ArgumentEncoder::~ArgumentEncoder()	50	ArgumentEncoder::~ArgumentEncoder()

Return to Bug 106321

Lines 1-3 a/Source/WebKit2/ChangeLog_sec1
- a/Source/WebKit2/ChangeLog +15 lines
		1	2013-01-08 Thiago Marcos P. Santos <thiago.santos@intel.com>
		2
		3	CoreIPC: Uninitialized data warnings when running on valgrind
		4	https://bugs.webkit.org/show_bug.cgi?id=106321
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	The contents of the inline buffer is being sent uninitialized
		9	when the size of the message is smaller than the buffer size.
		10	This is not exactly a problem but is an annoyance when debugging
		11	memory errors. memset()'ing on Debug builds hides the warnings.
		12
		13	* Platform/CoreIPC/ArgumentEncoder.cpp:
		14	(CoreIPC::ArgumentEncoder::ArgumentEncoder):
		15
1	2013-01-07 Christophe Dumez <christophe.dumez@intel.com>	16	2013-01-07 Christophe Dumez <christophe.dumez@intel.com>
2		17
3	[CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing	18	[CoordinatedGraphics] compositing/repaint/resize-repaint.html is failing