Attachment #178562 for bug #103036

View Details Raw Unified Return to Bug 103036

| Differences between



2012-12-10  Krzysztof Czech  <k.czech@samsung.com>, Laszlo Gombos  <l.gombos@samsung.com>

        [EFL] Possibility to turn off accessibility feature for WebKit-EFL.
        https://bugs.webkit.org/show_bug.cgi?id=103036

        Reviewed by NOBODY (OOPS!).

        Guard dependencies for accessibility (ATK), so that they can be turned off.

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmake/WebKitFeatures.cmake:

2012-12-08  Seokju Kwon  <seokju.kwon@gmail.com>

        [EFL][WK2] Add Remote Web Inspector



2012-12-10  Krzysztof Czech  <k.czech@samsung.com>, Laszlo Gombos  <l.gombos@samsung.com>

        [EFL] Possibility to turn off accessibility feature for WebKit-EFL.
        https://bugs.webkit.org/show_bug.cgi?id=103036

        Reviewed by NOBODY (OOPS!).

        Guard dependencies for accessibility (ATK), so that they can be turned off.

        No new tests as there is no new functionality.

        * PlatformEfl.cmake:
        * accessibility/AXObjectCache.h:
        (WebCore):
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postPlatformNotification):
        (WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
        (WebCore::AXObjectCache::handleScrolledToAnchor):
        (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
        * accessibility/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::AccessibilityObject):
        * accessibility/AccessibilityObject.h:
        (AccessibilityObject):
        (WebCore::AccessibilityObject::wrapper):
        (WebCore::AccessibilityObject::setWrapper):
        (WebCore):
        (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
        (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
        * accessibility/atk/AccessibilityObjectAtk.cpp:
        (WebCore):

2012-12-10  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: [Overrides] Unable to change values in Device Metrics override setting



list(APPEND WebCore_INCLUDE_DIRECTORIES
    "${WEBCORE_DIR}/accessibility/atk"
    "${WEBCORE_DIR}/page/efl"
    "${WEBCORE_DIR}/platform/cairo"
    "${WEBCORE_DIR}/platform/efl"

    "${WEBCORE_DIR}/platform/network/soup"
    "${WEBCORE_DIR}/platform/text/efl"
    "${WEBCORE_DIR}/plugins/efl"
    ${ATK_INCLUDE_DIRS}
)

list(APPEND WebCore_SOURCES
    accessibility/atk/AXObjectCacheAtk.cpp
    accessibility/atk/AccessibilityObjectAtk.cpp
    accessibility/atk/WebKitAccessibleHyperlink.cpp
    accessibility/atk/WebKitAccessibleInterfaceAction.cpp
    accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
    accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
    accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
    accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
    accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
    accessibility/atk/WebKitAccessibleInterfaceImage.cpp
    accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
    accessibility/atk/WebKitAccessibleInterfaceTable.cpp
    accessibility/atk/WebKitAccessibleInterfaceText.cpp
    accessibility/atk/WebKitAccessibleInterfaceValue.cpp
    accessibility/atk/WebKitAccessibleUtil.cpp
    accessibility/atk/WebKitAccessibleWrapperAtk.cpp
    editing/SmartReplaceICU.cpp
    page/efl/DragControllerEfl.cpp
    page/efl/EventHandlerEfl.cpp

endif ()

list(APPEND WebCore_LIBRARIES
    ${ATK_LIBRARIES}
    ${CAIRO_LIBRARIES}
    ${ECORE_LIBRARIES}
    ${ECORE_EVAS_LIBRARIES}

        ${ENCHANT_LIBRARIES}
    )
endif ()

if (ENABLE_ACCESSIBILITY)
    list(APPEND WebCore_SOURCES
        accessibility/atk/AccessibilityObjectAtk.cpp
        accessibility/atk/AXObjectCacheAtk.cpp
        accessibility/atk/WebKitAccessibleHyperlink.cpp
        accessibility/atk/WebKitAccessibleInterfaceAction.cpp
        accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
        accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
        accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
        accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
        accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
        accessibility/atk/WebKitAccessibleInterfaceImage.cpp
        accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
        accessibility/atk/WebKitAccessibleInterfaceTable.cpp
        accessibility/atk/WebKitAccessibleInterfaceText.cpp
        accessibility/atk/WebKitAccessibleInterfaceValue.cpp
        accessibility/atk/WebKitAccessibleUtil.cpp
        accessibility/atk/WebKitAccessibleWrapperAtk.cpp
    )
    list(APPEND WebCore_INCLUDE_DIRECTORIES
        "${WEBCORE_DIR}/accessibility/atk"
        ${ATK_INCLUDE_DIRS}
    )
    list(APPEND WebCore_LIBRARIES
        ${ATK_LIBRARIES}
    )
endif ()

Lines 270-275 inline void AXObjectCache::selectedChildrenChanged(RenderObject*) { } a/Source/WebCore/accessibility/AXObjectCache.h_sec1
- a/Source/WebCore/accessibility/AXObjectCache.h +9 lines
270	inline void AXObjectCache::selectedChildrenChanged(Node*) { }	270	inline void AXObjectCache::selectedChildrenChanged(Node*) { }
271	#endif	271	#endif
272		272
		273	#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
		274	inline void AXObjectCache::detachWrapper(AccessibilityObject*) { }
		275	inline void AXObjectCache::attachWrapper(AccessibilityObject*) { }
		276	inline void AXObjectCache::postPlatformNotification(AccessibilityObject*, AXNotification) { }
		277	inline void AXObjectCache::frameLoadingEventPlatformNotification(AccessibilityObject*, AXLoadingEvent) { }
		278	inline void AXObjectCache::handleScrolledToAnchor(const Node*) { }
		279	inline void AXObjectCache::nodeTextChangePlatformNotification(AccessibilityObject*, AXTextChange, unsigned, const String&) { }
		280	#endif
		281
273	}	282	}
274		283
275	#endif	284	#endif

Lines 74-80 AccessibilityObject::AccessibilityObject() a/Source/WebCore/accessibility/AccessibilityObject.cpp_sec1
- a/Source/WebCore/accessibility/AccessibilityObject.cpp -1 / +1 lines
74	, m_haveChildren(false)	74	, m_haveChildren(false)
75	, m_role(UnknownRole)	75	, m_role(UnknownRole)
76	, m_cachedIsIgnoredValue(DefaultBehavior)	76	, m_cachedIsIgnoredValue(DefaultBehavior)
77	#if PLATFORM(GTK) \|\| PLATFORM(EFL)	77	#if PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
78	, m_wrapper(0)	78	, m_wrapper(0)
79	#elif PLATFORM(CHROMIUM)	79	#elif PLATFORM(CHROMIUM)
80	, m_detached(false)	80	, m_detached(false)




typedef WebAccessibilityObjectWrapper AccessibilityObjectWrapper;

#elif PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
typedef struct _AtkObject AtkObject;
typedef struct _AtkObject AccessibilityObjectWrapper;
#elif PLATFORM(CHROMIUM)

    virtual String mathFencedCloseString() const { return String(); }
    
#if HAVE(ACCESSIBILITY)
#if PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
    AccessibilityObjectWrapper* wrapper() const;
    void setWrapper(AccessibilityObjectWrapper*);
#elif !PLATFORM(CHROMIUM) 
    AccessibilityObjectWrapper* wrapper() const
    {
#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
        return 0;
#else
        return m_wrapper.get();
#endif
    }
    void setWrapper(AccessibilityObjectWrapper* wrapper) 
    {
#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
        UNUSED_PARAM(wrapper);
#else
        m_wrapper = wrapper;
#endif
    }
#endif
#endif

    static bool objectMatchesSearchCriteriaWithResultLimit(AccessibilityObject*, AccessibilitySearchCriteria*, AccessibilityChildrenVector&);
    virtual AccessibilityRole buttonRoleType() const;
    
#if PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
    bool allowsTextRanges() const;
    unsigned getLengthForTextRange() const;
#else

    RetainPtr<WebAccessibilityObjectWrapper> m_wrapper;
#elif PLATFORM(WIN) && !OS(WINCE)
    COMPtr<AccessibilityObjectWrapper> m_wrapper;
#elif PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
    AtkObject* m_wrapper;
#elif PLATFORM(CHROMIUM)
    bool m_detached;

inline void AccessibilityObject::updateBackingStore() { }
#endif

#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
inline bool AccessibilityObject::accessibilityIgnoreAttachment() const  { return true; }
inline AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const { return DefaultBehavior; }
#endif

} // namespace WebCore

#endif // AccessibilityObject_h



    return DefaultBehavior;
}

#if PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
AccessibilityObjectWrapper* AccessibilityObject::wrapper() const
{
    return m_wrapper;


    return textLength;
}
#endif

} // namespace WebCore


Lines 46-51 file(MAKE_DIRECTORY ${THEME_BINARY_DIR}) a/Source/cmake/OptionsEfl.cmake_sec1
- a/Source/cmake/OptionsEfl.cmake -1 / +5 lines
46	set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")	46	set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter")
47		47
48	WEBKIT_OPTION_BEGIN()	48	WEBKIT_OPTION_BEGIN()
		49	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCESSIBILITY ON)
49	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_RENDERING ON)	50	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_3D_RENDERING ON)
50	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ANIMATION_API ON)	51	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ANIMATION_API ON)
51	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS ON)	52	WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_API_TESTS ON)
Lines 211-214 if (ENABLE_SPELLCHECK) a/Source/cmake/OptionsEfl.cmake_sec2
211	find_package(Enchant REQUIRED)	212	find_package(Enchant REQUIRED)
212	endif ()	213	endif ()
213		214
214	find_package(ATK REQUIRED)	215	if (ENABLE_ACCESSIBILITY)
		216	find_package(ATK REQUIRED)
		217	add_definitions(-DENABLE_ACCESSIBILITY_EFL=1)
		218	endif ()

Lines 13-18 endmacro() a/Source/cmake/WebKitFeatures.cmake_sec1
- a/Source/cmake/WebKitFeatures.cmake +1 lines
13	macro(WEBKIT_OPTION_BEGIN)	13	macro(WEBKIT_OPTION_BEGIN)
14	WEBKIT_OPTION_DEFINE(ENABLE_3D_RENDERING "Toggle 3D rendering support" OFF)	14	WEBKIT_OPTION_DEFINE(ENABLE_3D_RENDERING "Toggle 3D rendering support" OFF)
15	WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle accelerated 2D canvas support" OFF)	15	WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle accelerated 2D canvas support" OFF)
		16	WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY "Toggle accessibility support" OFF)
16	WEBKIT_OPTION_DEFINE(ENABLE_ANIMATION_API "Toggle animation API support" OFF)	17	WEBKIT_OPTION_DEFINE(ENABLE_ANIMATION_API "Toggle animation API support" OFF)
17	WEBKIT_OPTION_DEFINE(ENABLE_API_TESTS "Enable public API unit tests" OFF)	18	WEBKIT_OPTION_DEFINE(ENABLE_API_TESTS "Enable public API unit tests" OFF)
18	WEBKIT_OPTION_DEFINE(ENABLE_ASSEMBLER_WX_EXCLUSIVE "Toggel Assembler WX Exclusive support" OFF)	19	WEBKIT_OPTION_DEFINE(ENABLE_ASSEMBLER_WX_EXCLUSIVE "Toggel Assembler WX Exclusive support" OFF)



2012-12-10  Krzysztof Czech  <k.czech@samsung.com>

        [EFL] Possibility to turn off accessibility feature for WebKit-EFL.
        https://bugs.webkit.org/show_bug.cgi?id=103036

        Reviewed by NOBODY (OOPS!).

        Guard dependencies for accessibility (ATK), so that they can be turned off.

        * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
        (AccessibilityUIElement):
        * WebKitTestRunner/PlatformEfl.cmake:

2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>

        [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally



#include <oleacc.h>

typedef COMPtr<IAccessible> PlatformUIElement;
#elif PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
#include <atk/atk.h>
typedef AtkObject* PlatformUIElement;
#else

    void getDocumentLinks(Vector<RefPtr<AccessibilityUIElement> >&);
#endif

#if PLATFORM(MAC) || PLATFORM(GTK) || (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
    void getChildren(Vector<RefPtr<AccessibilityUIElement> >&);
    void getChildrenWithRange(Vector<RefPtr<AccessibilityUIElement> >&, unsigned location, unsigned length);
#endif



    ${TOOLS_DIR}/DumpRenderTree/efl/
    ${WEBKIT2_DIR}/UIProcess/API/efl
    "${WTF_DIR}/wtf/gobject"
    ${ATK_INCLUDE_DIRS}
    ${CAIRO_INCLUDE_DIRS}
    ${ECORE_INCLUDE_DIRS}
    ${ECORE_EVAS_INCLUDE_DIRS}

)

list(APPEND WebKitTestRunner_LIBRARIES
    ${ATK_LIBRARIES}
    ${CAIRO_LIBRARIES}
    ${ECORE_LIBRARIES}
    ${ECORE_EVAS_LIBRARIES}

list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
    ${TOOLS_DIR}/DumpRenderTree/efl/FontManagement.cpp

    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityControllerAtk.cpp
    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityUIElementAtk.cpp
    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/ActivateFontsEfl.cpp
    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/InjectedBundleEfl.cpp
    ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/TestRunnerEfl.cpp

add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/DumpRenderTree/gtk/fonts"
                -DDOWNLOADED_FONTS_DIR="${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3"
                -DTHEME_DIR="${THEME_BINARY_DIR}")

if (ENABLE_ACCESSIBILITY)
    list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
        ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityControllerAtk.cpp
        ${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityUIElementAtk.cpp
    )
    list(APPEND WebKitTestRunner_INCLUDE_DIRECTORIES
        ${ATK_INCLUDE_DIRS}
    )
    list(APPEND WebKitTestRunner_LIBRARIES
        ${ATK_LIBRARIES}
    )
endif ()

Return to Bug 103036

Lines 61-67 OBJC_CLASS WebAccessibilityObjectWrapper; a/Source/WebCore/accessibility/AccessibilityObject.h_sec1
- a/Source/WebCore/accessibility/AccessibilityObject.h -6 / +22 lines
61		61
62	typedef WebAccessibilityObjectWrapper AccessibilityObjectWrapper;	62	typedef WebAccessibilityObjectWrapper AccessibilityObjectWrapper;
63		63
64	#elif PLATFORM(GTK) \|\| PLATFORM(EFL)	64	#elif PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
65	typedef struct _AtkObject AtkObject;	65	typedef struct _AtkObject AtkObject;
66	typedef struct _AtkObject AccessibilityObjectWrapper;	66	typedef struct _AtkObject AccessibilityObjectWrapper;
67	#elif PLATFORM(CHROMIUM)	67	#elif PLATFORM(CHROMIUM)
Lines 778-791 public: a/Source/WebCore/accessibility/AccessibilityObject.h_sec2
778	virtual String mathFencedCloseString() const { return String(); }	778	virtual String mathFencedCloseString() const { return String(); }
779		779
780	#if HAVE(ACCESSIBILITY)	780	#if HAVE(ACCESSIBILITY)
781	#if PLATFORM(GTK) \|\| PLATFORM(EFL)	781	#if PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
782	AccessibilityObjectWrapper* wrapper() const;	782	AccessibilityObjectWrapper* wrapper() const;
783	void setWrapper(AccessibilityObjectWrapper*);	783	void setWrapper(AccessibilityObjectWrapper*);
784	#elif !PLATFORM(CHROMIUM)	784	#elif !PLATFORM(CHROMIUM)
785	AccessibilityObjectWrapper* wrapper() const { return m_wrapper.get(); }	785	AccessibilityObjectWrapper* wrapper() const
		786	{
		787	#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
		788	return 0;
		789	#else
		790	return m_wrapper.get();
		791	#endif
		792	}
786	void setWrapper(AccessibilityObjectWrapper* wrapper)	793	void setWrapper(AccessibilityObjectWrapper* wrapper)
787	{	794	{
		795	#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
		796	UNUSED_PARAM(wrapper);
		797	#else
788	m_wrapper = wrapper;	798	m_wrapper = wrapper;
		799	#endif
789	}	800	}
790	#endif	801	#endif
791	#endif	802	#endif
Lines 826-832 protected: a/Source/WebCore/accessibility/AccessibilityObject.h_sec3
826	static bool objectMatchesSearchCriteriaWithResultLimit(AccessibilityObject, AccessibilitySearchCriteria, AccessibilityChildrenVector&);	837	static bool objectMatchesSearchCriteriaWithResultLimit(AccessibilityObject, AccessibilitySearchCriteria, AccessibilityChildrenVector&);
827	virtual AccessibilityRole buttonRoleType() const;	838	virtual AccessibilityRole buttonRoleType() const;
828		839
829	#if PLATFORM(GTK) \|\| PLATFORM(EFL)	840	#if PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
830	bool allowsTextRanges() const;	841	bool allowsTextRanges() const;
831	unsigned getLengthForTextRange() const;	842	unsigned getLengthForTextRange() const;
832	#else	843	#else
Lines 838-844 protected: a/Source/WebCore/accessibility/AccessibilityObject.h_sec4
838	RetainPtr<WebAccessibilityObjectWrapper> m_wrapper;	849	RetainPtr<WebAccessibilityObjectWrapper> m_wrapper;
839	#elif PLATFORM(WIN) && !OS(WINCE)	850	#elif PLATFORM(WIN) && !OS(WINCE)
840	COMPtr<AccessibilityObjectWrapper> m_wrapper;	851	COMPtr<AccessibilityObjectWrapper> m_wrapper;
841	#elif PLATFORM(GTK) \|\| PLATFORM(EFL)	852	#elif PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
842	AtkObject* m_wrapper;	853	AtkObject* m_wrapper;
843	#elif PLATFORM(CHROMIUM)	854	#elif PLATFORM(CHROMIUM)
844	bool m_detached;	855	bool m_detached;
Lines 852-857 inline int AccessibilityObject::lineForPosition(const VisiblePosition&) const { a/Source/WebCore/accessibility/AccessibilityObject.h_sec5
852	inline void AccessibilityObject::updateBackingStore() { }	863	inline void AccessibilityObject::updateBackingStore() { }
853	#endif	864	#endif
854		865
		866	#if (PLATFORM(EFL) && !ENABLE(ACCESSIBILITY_EFL))
		867	inline bool AccessibilityObject::accessibilityIgnoreAttachment() const { return true; }
		868	inline AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesObject() const { return DefaultBehavior; }
		869	#endif
		870
855	} // namespace WebCore	871	} // namespace WebCore
856		872
857	#endif // AccessibilityObject_h	873	#endif // AccessibilityObject_h

Lines 114-119 AccessibilityObjectInclusion AccessibilityObject::accessibilityPlatformIncludesO a/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp_sec1
- a/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp +2 lines
114	return DefaultBehavior;	114	return DefaultBehavior;
115	}	115	}
116		116
		117	#if PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
117	AccessibilityObjectWrapper* AccessibilityObject::wrapper() const	118	AccessibilityObjectWrapper* AccessibilityObject::wrapper() const
118	{	119	{
119	return m_wrapper;	120	return m_wrapper;
Lines 166-171 unsigned AccessibilityObject::getLengthForTextRange() const a/Source/WebCore/accessibility/atk/AccessibilityObjectAtk.cpp_sec2
166		167
167	return textLength;	168	return textLength;
168	}	169	}
		170	#endif
169		171
170	} // namespace WebCore	172	} // namespace WebCore
171		173

Lines 1-3 a/ChangeLog_sec1
- a/ChangeLog +12 lines
		1	2012-12-10 Krzysztof Czech <k.czech@samsung.com>, Laszlo Gombos <l.gombos@samsung.com>
		2
		3	[EFL] Possibility to turn off accessibility feature for WebKit-EFL.
		4	https://bugs.webkit.org/show_bug.cgi?id=103036
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Guard dependencies for accessibility (ATK), so that they can be turned off.
		9
		10	* Source/cmake/OptionsEfl.cmake:
		11	* Source/cmake/WebKitFeatures.cmake:
		12
1	2012-12-08 Seokju Kwon <seokju.kwon@gmail.com>	13	2012-12-08 Seokju Kwon <seokju.kwon@gmail.com>
2		14
3	[EFL][WK2] Add Remote Web Inspector	15	[EFL][WK2] Add Remote Web Inspector

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +32 lines
		1	2012-12-10 Krzysztof Czech <k.czech@samsung.com>, Laszlo Gombos <l.gombos@samsung.com>
		2
		3	[EFL] Possibility to turn off accessibility feature for WebKit-EFL.
		4	https://bugs.webkit.org/show_bug.cgi?id=103036
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Guard dependencies for accessibility (ATK), so that they can be turned off.
		9
		10	No new tests as there is no new functionality.
		11
		12	* PlatformEfl.cmake:
		13	* accessibility/AXObjectCache.h:
		14	(WebCore):
		15	(WebCore::AXObjectCache::detachWrapper):
		16	(WebCore::AXObjectCache::attachWrapper):
		17	(WebCore::AXObjectCache::postPlatformNotification):
		18	(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
		19	(WebCore::AXObjectCache::handleScrolledToAnchor):
		20	(WebCore::AXObjectCache::nodeTextChangePlatformNotification):
		21	* accessibility/AccessibilityObject.cpp:
		22	(WebCore::AccessibilityObject::AccessibilityObject):
		23	* accessibility/AccessibilityObject.h:
		24	(AccessibilityObject):
		25	(WebCore::AccessibilityObject::wrapper):
		26	(WebCore::AccessibilityObject::setWrapper):
		27	(WebCore):
		28	(WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
		29	(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
		30	* accessibility/atk/AccessibilityObjectAtk.cpp:
		31	(WebCore):
		32
1	2012-12-10 Alexander Pavlov <apavlov@chromium.org>	33	2012-12-10 Alexander Pavlov <apavlov@chromium.org>
2		34
3	Web Inspector: [Overrides] Unable to change values in Device Metrics override setting	35	Web Inspector: [Overrides] Unable to change values in Device Metrics override setting

Lines 1-5 a/Source/WebCore/PlatformEfl.cmake_sec1
- a/Source/WebCore/PlatformEfl.cmake -19 / +28 lines
1	list(APPEND WebCore_INCLUDE_DIRECTORIES	1	list(APPEND WebCore_INCLUDE_DIRECTORIES
2	"${WEBCORE_DIR}/accessibility/atk"
3	"${WEBCORE_DIR}/page/efl"	2	"${WEBCORE_DIR}/page/efl"
4	"${WEBCORE_DIR}/platform/cairo"	3	"${WEBCORE_DIR}/platform/cairo"
5	"${WEBCORE_DIR}/platform/efl"	4	"${WEBCORE_DIR}/platform/efl"
Lines 13-38 list(APPEND WebCore_INCLUDE_DIRECTORIES a/Source/WebCore/PlatformEfl.cmake_sec2
13	"${WEBCORE_DIR}/platform/network/soup"	12	"${WEBCORE_DIR}/platform/network/soup"
14	"${WEBCORE_DIR}/platform/text/efl"	13	"${WEBCORE_DIR}/platform/text/efl"
15	"${WEBCORE_DIR}/plugins/efl"	14	"${WEBCORE_DIR}/plugins/efl"
16	${ATK_INCLUDE_DIRS}
17	)	15	)
18		16
19	list(APPEND WebCore_SOURCES	17	list(APPEND WebCore_SOURCES
20	accessibility/atk/AXObjectCacheAtk.cpp
21	accessibility/atk/AccessibilityObjectAtk.cpp
22	accessibility/atk/WebKitAccessibleHyperlink.cpp
23	accessibility/atk/WebKitAccessibleInterfaceAction.cpp
24	accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
25	accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
26	accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
27	accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
28	accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
29	accessibility/atk/WebKitAccessibleInterfaceImage.cpp
30	accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
31	accessibility/atk/WebKitAccessibleInterfaceTable.cpp
32	accessibility/atk/WebKitAccessibleInterfaceText.cpp
33	accessibility/atk/WebKitAccessibleInterfaceValue.cpp
34	accessibility/atk/WebKitAccessibleUtil.cpp
35	accessibility/atk/WebKitAccessibleWrapperAtk.cpp
36	editing/SmartReplaceICU.cpp	18	editing/SmartReplaceICU.cpp
37	page/efl/DragControllerEfl.cpp	19	page/efl/DragControllerEfl.cpp
38	page/efl/EventHandlerEfl.cpp	20	page/efl/EventHandlerEfl.cpp
Lines 177-183 if (WTF_USE_TEXTURE_MAPPER) a/Source/WebCore/PlatformEfl.cmake_sec3
177	endif ()	159	endif ()
178		160
179	list(APPEND WebCore_LIBRARIES	161	list(APPEND WebCore_LIBRARIES
180	${ATK_LIBRARIES}
181	${CAIRO_LIBRARIES}	162	${CAIRO_LIBRARIES}
182	${ECORE_LIBRARIES}	163	${ECORE_LIBRARIES}
183	${ECORE_EVAS_LIBRARIES}	164	${ECORE_EVAS_LIBRARIES}
Lines 338-340 if (ENABLE_SPELLCHECK) a/Source/WebCore/PlatformEfl.cmake_sec4
338	${ENCHANT_LIBRARIES}	319	${ENCHANT_LIBRARIES}
339	)	320	)
340	endif ()	321	endif ()
		322
		323	if (ENABLE_ACCESSIBILITY)
		324	list(APPEND WebCore_SOURCES
		325	accessibility/atk/AccessibilityObjectAtk.cpp
		326	accessibility/atk/AXObjectCacheAtk.cpp
		327	accessibility/atk/WebKitAccessibleHyperlink.cpp
		328	accessibility/atk/WebKitAccessibleInterfaceAction.cpp
		329	accessibility/atk/WebKitAccessibleInterfaceComponent.cpp
		330	accessibility/atk/WebKitAccessibleInterfaceDocument.cpp
		331	accessibility/atk/WebKitAccessibleInterfaceEditableText.cpp
		332	accessibility/atk/WebKitAccessibleInterfaceHyperlinkImpl.cpp
		333	accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp
		334	accessibility/atk/WebKitAccessibleInterfaceImage.cpp
		335	accessibility/atk/WebKitAccessibleInterfaceSelection.cpp
		336	accessibility/atk/WebKitAccessibleInterfaceTable.cpp
		337	accessibility/atk/WebKitAccessibleInterfaceText.cpp
		338	accessibility/atk/WebKitAccessibleInterfaceValue.cpp
		339	accessibility/atk/WebKitAccessibleUtil.cpp
		340	accessibility/atk/WebKitAccessibleWrapperAtk.cpp
		341	)
		342	list(APPEND WebCore_INCLUDE_DIRECTORIES
		343	"${WEBCORE_DIR}/accessibility/atk"
		344	${ATK_INCLUDE_DIRS}
		345	)
		346	list(APPEND WebCore_LIBRARIES
		347	${ATK_LIBRARIES}
		348	)
		349	endif ()

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +13 lines
		1	2012-12-10 Krzysztof Czech <k.czech@samsung.com>
		2
		3	[EFL] Possibility to turn off accessibility feature for WebKit-EFL.
		4	https://bugs.webkit.org/show_bug.cgi?id=103036
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Guard dependencies for accessibility (ATK), so that they can be turned off.
		9
		10	* WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
		11	(AccessibilityUIElement):
		12	* WebKitTestRunner/PlatformEfl.cmake:
		13
1	2012-12-10 Simon Hausmann <simon.hausmann@digia.com>	14	2012-12-10 Simon Hausmann <simon.hausmann@digia.com>
2		15
3	[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally	16	[Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally

Lines 49-55 typedef struct objc_object* PlatformUIElement; a/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h_sec1
- a/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h -2 / +2 lines
49	#include <oleacc.h>	49	#include <oleacc.h>
50		50
51	typedef COMPtr<IAccessible> PlatformUIElement;	51	typedef COMPtr<IAccessible> PlatformUIElement;
52	#elif PLATFORM(GTK) \|\| PLATFORM(EFL)	52	#elif PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
53	#include <atk/atk.h>	53	#include <atk/atk.h>
54	typedef AtkObject* PlatformUIElement;	54	typedef AtkObject* PlatformUIElement;
55	#else	55	#else
Lines 245-251 private: a/Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h_sec2
245	void getDocumentLinks(Vector<RefPtr<AccessibilityUIElement> >&);	245	void getDocumentLinks(Vector<RefPtr<AccessibilityUIElement> >&);
246	#endif	246	#endif
247		247
248	#if PLATFORM(MAC) \|\| PLATFORM(GTK) \|\| PLATFORM(EFL)	248	#if PLATFORM(MAC) \|\| PLATFORM(GTK) \|\| (PLATFORM(EFL) && ENABLE(ACCESSIBILITY_EFL))
249	void getChildren(Vector<RefPtr<AccessibilityUIElement> >&);	249	void getChildren(Vector<RefPtr<AccessibilityUIElement> >&);
250	void getChildrenWithRange(Vector<RefPtr<AccessibilityUIElement> >&, unsigned location, unsigned length);	250	void getChildrenWithRange(Vector<RefPtr<AccessibilityUIElement> >&, unsigned location, unsigned length);
251	#endif	251	#endif

Lines 21-27 list(APPEND WebKitTestRunner_INCLUDE_DIRECTORIES a/Tools/WebKitTestRunner/PlatformEfl.cmake_sec1
- a/Tools/WebKitTestRunner/PlatformEfl.cmake -4 / +13 lines
21	${TOOLS_DIR}/DumpRenderTree/efl/	21	${TOOLS_DIR}/DumpRenderTree/efl/
22	${WEBKIT2_DIR}/UIProcess/API/efl	22	${WEBKIT2_DIR}/UIProcess/API/efl
23	"${WTF_DIR}/wtf/gobject"	23	"${WTF_DIR}/wtf/gobject"
24	${ATK_INCLUDE_DIRS}
25	${CAIRO_INCLUDE_DIRS}	24	${CAIRO_INCLUDE_DIRS}
26	${ECORE_INCLUDE_DIRS}	25	${ECORE_INCLUDE_DIRS}
27	${ECORE_EVAS_INCLUDE_DIRS}	26	${ECORE_EVAS_INCLUDE_DIRS}
Lines 31-37 list(APPEND WebKitTestRunner_INCLUDE_DIRECTORIES a/Tools/WebKitTestRunner/PlatformEfl.cmake_sec2
31	)	30	)
32		31
33	list(APPEND WebKitTestRunner_LIBRARIES	32	list(APPEND WebKitTestRunner_LIBRARIES
34	${ATK_LIBRARIES}
35	${CAIRO_LIBRARIES}	33	${CAIRO_LIBRARIES}
36	${ECORE_LIBRARIES}	34	${ECORE_LIBRARIES}
37	${ECORE_EVAS_LIBRARIES}	35	${ECORE_EVAS_LIBRARIES}
Lines 56-63 endif () a/Tools/WebKitTestRunner/PlatformEfl.cmake_sec3
56	list(APPEND WebKitTestRunnerInjectedBundle_SOURCES	54	list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
57	${TOOLS_DIR}/DumpRenderTree/efl/FontManagement.cpp	55	${TOOLS_DIR}/DumpRenderTree/efl/FontManagement.cpp
58		56
59	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityControllerAtk.cpp
60	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityUIElementAtk.cpp
61	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/ActivateFontsEfl.cpp	57	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/ActivateFontsEfl.cpp
62	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/InjectedBundleEfl.cpp	58	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/InjectedBundleEfl.cpp
63	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/TestRunnerEfl.cpp	59	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/efl/TestRunnerEfl.cpp
Lines 68-70 list(APPEND WebKitTestRunnerInjectedBundle_SOURCES a/Tools/WebKitTestRunner/PlatformEfl.cmake_sec4
68	add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/DumpRenderTree/gtk/fonts"	64	add_definitions(-DFONTS_CONF_DIR="${TOOLS_DIR}/DumpRenderTree/gtk/fonts"
69	-DDOWNLOADED_FONTS_DIR="${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3"	65	-DDOWNLOADED_FONTS_DIR="${CMAKE_SOURCE_DIR}/WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3"
70	-DTHEME_DIR="${THEME_BINARY_DIR}")	66	-DTHEME_DIR="${THEME_BINARY_DIR}")
		67
		68	if (ENABLE_ACCESSIBILITY)
		69	list(APPEND WebKitTestRunnerInjectedBundle_SOURCES
		70	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityControllerAtk.cpp
		71	${WEBKIT_TESTRUNNER_INJECTEDBUNDLE_DIR}/atk/AccessibilityUIElementAtk.cpp
		72	)
		73	list(APPEND WebKitTestRunner_INCLUDE_DIRECTORIES
		74	${ATK_INCLUDE_DIRS}
		75	)
		76	list(APPEND WebKitTestRunner_LIBRARIES
		77	${ATK_LIBRARIES}
		78	)
		79	endif ()