Attachment #177318 for bug #95563

View Details Raw Unified Return to Bug 95563

| Differences between



2012-12-03  Michael Pruett  <michael@68k.org>

        [JSC] Clear exceptions thrown in Dictionary
        https://bugs.webkit.org/show_bug.cgi?id=95563

        Reviewed by NOBODY (OOPS!).

        Exceptions thrown in Dictionary should be cleared so that subsequent
        accesses do not fail spuriously. This change is needed to implement
        IndexedDB for JSC.

        Tests: storage/indexeddb/*

        * bindings/js/Dictionary.cpp:
        (WebCore::Dictionary::getWithUndefinedOrNullCheck):
        * bindings/js/Dictionary.h:
        (WebCore::Dictionary::get):

2012-11-29  Michael Pruett  <michael@68k.org>

        IndexedDB: Implement IndexedDB bindings for JSC

Lines 100-106 bool Dictionary::getOwnPropertyNames(Vector<String>& names) const a/Source/WebCore/bindings/js/Dictionary.cpp_sec1
- a/Source/WebCore/bindings/js/Dictionary.cpp -1 / +4 lines
100		100
101	bool Dictionary::getWithUndefinedOrNullCheck(const String& propertyName, String& value) const	101	bool Dictionary::getWithUndefinedOrNullCheck(const String& propertyName, String& value) const
102	{	102	{
103	return m_dictionary.getWithUndefinedOrNullCheck(propertyName, value);	103	bool success = m_dictionary.getWithUndefinedOrNullCheck(propertyName, value);
		104	if (m_dictionary.execState()->hadException())
		105	m_dictionary.execState()->clearException();
		106	return success;
104	}	107	}
105		108
106	};	109	};

Lines 77-83 bool Dictionary::get(const char* propertyName, Result& result) const a/Source/WebCore/bindings/js/Dictionary.h_sec1
- a/Source/WebCore/bindings/js/Dictionary.h -2 / +4 lines
77	if (!m_dictionary.isValid())	77	if (!m_dictionary.isValid())
78	return false;	78	return false;
79		79
80	return m_dictionary.get(propertyName, result);	80	bool success = m_dictionary.get(propertyName, result);
		81	if (m_dictionary.execState()->hadException())
		82	m_dictionary.execState()->clearException();
		83	return success;
81	}	84	}
82		85
83	template <typename Result>	86	template <typename Result>
84	-

Return to Bug 95563

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +18 lines
		1	2012-12-03 Michael Pruett <michael@68k.org>
		2
		3	[JSC] Clear exceptions thrown in Dictionary
		4	https://bugs.webkit.org/show_bug.cgi?id=95563
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Exceptions thrown in Dictionary should be cleared so that subsequent
		9	accesses do not fail spuriously. This change is needed to implement
		10	IndexedDB for JSC.
		11
		12	Tests: storage/indexeddb/*
		13
		14	* bindings/js/Dictionary.cpp:
		15	(WebCore::Dictionary::getWithUndefinedOrNullCheck):
		16	* bindings/js/Dictionary.h:
		17	(WebCore::Dictionary::get):
		18
1	2012-11-29 Michael Pruett <michael@68k.org>	19	2012-11-29 Michael Pruett <michael@68k.org>
2		20
3	IndexedDB: Implement IndexedDB bindings for JSC	21	IndexedDB: Implement IndexedDB bindings for JSC