Attachment #164748 for bug #96521

View Details Raw Unified Return to Bug 96521

| Differences between



2012-09-19  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Remove unused popupsAllowed function from PlatformSupport
        https://bugs.webkit.org/show_bug.cgi?id=96521

        Reviewed by Eric Seidel.

        Part of a refactoring series. See tracking bug 82948.

        * bindings/v8/NPV8Object.cpp:
        (WebCore::v8ObjectToNPObject):
        (_NPN_Evaluate):
        (_NPN_GetProperty):
        * platform/chromium/PlatformSupport.h:
        (PlatformSupport):

2012-09-19  Raul Hudea  <rhudea@adobe.com>

        [CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined




#include "NPV8Object.h"

#include "PlatformSupport.h"
#include "DOMWindow.h"
#include "Frame.h"
#include "NPObjectWrapper.h"


bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
{
    // FIXME: Give the embedder a way to control this.
    bool popupsAllowed = false;
    return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
}


Lines 119-125 public: Source/WebCore/platform/chromium/PlatformSupport.h_sec1
- Source/WebCore/platform/chromium/PlatformSupport.h -1 lines
119	// Plugin -------------------------------------------------------------	119	// Plugin -------------------------------------------------------------
120	static bool plugins(bool refresh, Vector<PluginInfo>*);	120	static bool plugins(bool refresh, Vector<PluginInfo>*);
121	static NPObject* pluginScriptableObject(Widget*);	121	static NPObject* pluginScriptableObject(Widget*);
122	static bool popupsAllowed(NPP);
123		122
124	// Screen -------------------------------------------------------------	123	// Screen -------------------------------------------------------------
125	static int screenHorizontalDPI(Widget*);	124	static int screenHorizontalDPI(Widget*);



2012-09-19  Mark Pilgrim  <pilgrim@chromium.org>

        [Chromium] Remove unused popupsAllowed function from PlatformSupport
        https://bugs.webkit.org/show_bug.cgi?id=96521

        Reviewed by Eric Seidel.

        Part of a refactoring series. See tracking bug 82948.

        * src/PlatformSupport.cpp:
        (WebCore):

2012-09-19  Kent Tamura  <tkent@chromium.org>

        [Chromium] Fix crash in WebFrameImpl::loadHistoryItem



    return client->screenInfo().availableRect;
}

bool PlatformSupport::popupsAllowed(NPP npp)
{
    // FIXME: Give the embedder a way to control this.
    return false;
}

#if ENABLE(WORKERS)
WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
{

Return to Bug 96521

Lines 28-34 Source/WebCore/bindings/v8/NPV8Object.cpp_sec1
- Source/WebCore/bindings/v8/NPV8Object.cpp -2 / +2 lines
28		28
29	#include "NPV8Object.h"	29	#include "NPV8Object.h"
30		30
31	#include "PlatformSupport.h"
32	#include "DOMWindow.h"	31	#include "DOMWindow.h"
33	#include "Frame.h"	32	#include "Frame.h"
34	#include "NPObjectWrapper.h"	33	#include "NPObjectWrapper.h"
Lines 296-302 bool _NPN_InvokeDefault(NPP npp, NPObjec Source/WebCore/bindings/v8/NPV8Object.cpp_sec2
296		295
297	bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)	296	bool _NPN_Evaluate(NPP npp, NPObject* npObject, NPString* npScript, NPVariant* result)
298	{	297	{
299	bool popupsAllowed = PlatformSupport::popupsAllowed(npp);	298	// FIXME: Give the embedder a way to control this.
		299	bool popupsAllowed = false;
300	return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);	300	return _NPN_EvaluateHelper(npp, popupsAllowed, npObject, npScript, result);
301	}	301	}
302		302

Lines 566-577 IntRect PlatformSupport::screenAvailable Source/WebKit/chromium/src/PlatformSupport.cpp_sec1
- Source/WebKit/chromium/src/PlatformSupport.cpp -6 lines
566	return client->screenInfo().availableRect;	566	return client->screenInfo().availableRect;
567	}	567	}
568		568
569	bool PlatformSupport::popupsAllowed(NPP npp)
570	{
571	// FIXME: Give the embedder a way to control this.
572	return false;
573	}
574
575	#if ENABLE(WORKERS)	569	#if ENABLE(WORKERS)
576	WorkerContextProxy* WorkerContextProxy::create(Worker* worker)	570	WorkerContextProxy* WorkerContextProxy::create(Worker* worker)
577	{	571	{

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +16 lines
		1	2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
		2
		3	[Chromium] Remove unused popupsAllowed function from PlatformSupport
		4	https://bugs.webkit.org/show_bug.cgi?id=96521
		5
		6	Reviewed by Eric Seidel.
		7
		8	Part of a refactoring series. See tracking bug 82948.
		9
		10	* bindings/v8/NPV8Object.cpp:
		11	(WebCore::v8ObjectToNPObject):
		12	(_NPN_Evaluate):
		13	(_NPN_GetProperty):
		14	* platform/chromium/PlatformSupport.h:
		15	(PlatformSupport):
		16
1	2012-09-19 Raul Hudea <rhudea@adobe.com>	17	2012-09-19 Raul Hudea <rhudea@adobe.com>
2		18
3	[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined	19	[CSSRegions][CSSOM] Make sure all Regions APIs are not visible if CSS_REGIONS is not defined

Lines 1-3 Source/WebKit/chromium/ChangeLog_sec1
- Source/WebKit/chromium/ChangeLog +12 lines
		1	2012-09-19 Mark Pilgrim <pilgrim@chromium.org>
		2
		3	[Chromium] Remove unused popupsAllowed function from PlatformSupport
		4	https://bugs.webkit.org/show_bug.cgi?id=96521
		5
		6	Reviewed by Eric Seidel.
		7
		8	Part of a refactoring series. See tracking bug 82948.
		9
		10	* src/PlatformSupport.cpp:
		11	(WebCore):
		12
1	2012-09-19 Kent Tamura <tkent@chromium.org>	13	2012-09-19 Kent Tamura <tkent@chromium.org>
2		14
3	[Chromium] Fix crash in WebFrameImpl::loadHistoryItem	15	[Chromium] Fix crash in WebFrameImpl::loadHistoryItem