Attachment #155257 for bug #92627

View Details Raw Unified Return to Bug 92627



2012-07-30  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=92627

        Reviewed by NOBODY (OOPS!).

        Remove the default behavior I added in r123729 so that we run all tests as pixel
        test with -p. It was intentional but it seems like we don't have consensus on
        that we want it.

        * Scripts/webkitpy/layout_tests/port/qt.py:
        (QtPort._supports_switching_pixel_tests_per_test):

2012-07-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>

        [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.



    def _supports_switching_pixel_tests_per_test(self):
        return True

    def _should_run_as_pixel_test(self, test_input):
        return any(test_input.test_name.startswith(directory)
                   for directory in QtPort._default_pixel_test_directories())

    @staticmethod
    def _default_pixel_test_directories():
        return ['compositing']

Return to Bug 92627

Lines 187-196 class QtPort(Port): a/Tools/Scripts/webkitpy/layout_tests/port/qt.py_sec1
- a/Tools/Scripts/webkitpy/layout_tests/port/qt.py -7 lines
187	def _supports_switching_pixel_tests_per_test(self):	187	def _supports_switching_pixel_tests_per_test(self):
188	return True	188	return True
189		189
190	def _should_run_as_pixel_test(self, test_input):
191	return any(test_input.test_name.startswith(directory)
192	for directory in QtPort._default_pixel_test_directories())
193
194	@staticmethod
195	def _default_pixel_test_directories():
196	return ['compositing']

Lines 1-3 a/Tools/ChangeLog_sec1
- a/Tools/ChangeLog +14 lines
		1	2012-07-30 Balazs Kelemen <kbalazs@webkit.org>
		2
		3	[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work
		4	https://bugs.webkit.org/show_bug.cgi?id=92627
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Remove the default behavior I added in r123729 so that we run all tests as pixel
		9	test with -p. It was intentional but it seems like we don't have consensus on
		10	that we want it.
		11
		12	* Scripts/webkitpy/layout_tests/port/qt.py:
		13	(QtPort._supports_switching_pixel_tests_per_test):
		14
1	2012-07-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>	15	2012-07-30 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
2		16
3	[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.	17	[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender.