Attachment #106411 for bug #66937

View Details Raw Unified Return to Bug 66937

| Differences between



2011-09-06  Sameer Patil  <mkrp87@motorola.com>

        Locking padding size of input type search element on Webkit-GTK.
        https://bugs.webkit.org/show_bug.cgi?id=66937

        Reviewed by NOBODY (OOPS!).

        Test: fast/forms/search-styled-padding.html

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::adjustSearchFieldStyle):
        Locking input type search element padding so it will render as par with Safari when padding of search
        element is more than 1px.
        Also setting outline offset when input type search element is active to avoid focus ring looking
        outset to input element box.

2011-09-06  Rob Buis  <rbuis@rim.com>

        use after free in WebCore::SVGTRefElement::updateReferencedText

Lines 27-32 Source/WebCore/platform/gtk/RenderThemeGtk.cpp_sec1
- Source/WebCore/platform/gtk/RenderThemeGtk.cpp +9 lines
27		27
28	#include "CSSValueKeywords.h"	28	#include "CSSValueKeywords.h"
29	#include "FileSystem.h"	29	#include "FileSystem.h"
		30	#include "Frame.h"
30	#include "GOwnPtr.h"	31	#include "GOwnPtr.h"
31	#include "Gradient.h"	32	#include "Gradient.h"
32	#include "GraphicsContext.h"	33	#include "GraphicsContext.h"
Lines 364-369 void RenderThemeGtk::adjustSearchFieldSt Source/WebCore/platform/gtk/RenderThemeGtk.cpp_sec2
364	// We cannot give a proper rendering when border radius is active, unfortunately.	365	// We cannot give a proper rendering when border radius is active, unfortunately.
365	style->resetBorderRadius();	366	style->resetBorderRadius();
366	style->setLineHeight(RenderStyle::initialLineHeight());	367	style->setLineHeight(RenderStyle::initialLineHeight());
		368
		369	const int padding = 1;
		370	style->setPaddingLeft(Length(padding, Fixed));
		371	style->setPaddingRight(Length(padding, Fixed));
		372	style->setPaddingTop(Length(padding, Fixed));
		373	style->setPaddingBottom(Length(padding, Fixed));
		374	if (e && e->focused() && e->document()->frame()->selection()->isFocusedAndActive())
		375	style->setOutlineOffset(-2);
367	}	376	}
368		377
369	bool RenderThemeGtk::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& rect)	378	bool RenderThemeGtk::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& rect)



2011-09-06  Sameer Patil  <mkrp87@motorola.com>

        Padding size of input type search element is not locked on Webkit-GTK.
        https://bugs.webkit.org/show_bug.cgi?id=66937

        Reviewed by NOBODY (OOPS!).

        * fast/forms/search-styled-padding.html: Added.
        * platform/gtk/fast/forms/search-styled-expected.txt:
        * platform/gtk/fast/forms/search-styled-padding-expected.txt: Added.

2011-09-06  Rob Buis  <rbuis@rim.com>

        use after free in WebCore::SVGTRefElement::updateReferencedText



<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<style>
.inputsearch{padding-left: 25px;padding-right: 25px;padding-top: 25px;padding-bottom: 25px;}
</style>
</head>
<body>
<input type="search" class="inputsearch" title="Input type Search element" value="" results="10" />
</body>
</html>



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x38
  RenderBlock {HTML} at (0,0) size 800x38
    RenderBody {BODY} at (8,8) size 784x22
      RenderTextControl {INPUT} at (2,3) size 130x17 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
        RenderDeprecatedFlexibleBox {DIV} at (2,2) size 126x13
          RenderBlock {DIV} at (0,1) size 11x11
          RenderBlock {DIV} at (11,0) size 104x13
          RenderBlock {DIV} at (115,1) size 11x11
      RenderText {#text} at (0,0) size 0x0
layer at (23,13) size 104x13
  RenderBlock {DIV} at (0,0) size 104x13
layer at (23,13) size 104x13
  RenderBlock (relative positioned) {DIV} at (13,2) size 104x13 [color=#A9A9A9]
    RenderText {#text} at (1,0) size 88x13
      text run at (1,0) width 88: "Search for Events"



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x45
  RenderBlock {HTML} at (0,0) size 800x45
    RenderBody {BODY} at (8,8) size 784x29
      RenderTextControl {INPUT} at (2,2) size 194x25 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
        RenderDeprecatedFlexibleBox {DIV} at (3,3) size 188x19
          RenderBlock {DIV} at (0,1) size 16x16
          RenderBlock {DIV} at (16,0) size 156x19
          RenderBlock {DIV} at (172,1) size 16x16
      RenderText {#text} at (0,0) size 0x0
layer at (29,13) size 156x19
  RenderBlock {DIV} at (0,0) size 156x19

Return to Bug 66937

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +16 lines
		1	2011-09-06 Sameer Patil <mkrp87@motorola.com>
		2
		3	Locking padding size of input type search element on Webkit-GTK.
		4	https://bugs.webkit.org/show_bug.cgi?id=66937
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Test: fast/forms/search-styled-padding.html
		9
		10	* platform/gtk/RenderThemeGtk.cpp:
		11	(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
		12	Locking input type search element padding so it will render as par with Safari when padding of search
		13	element is more than 1px.
		14	Also setting outline offset when input type search element is active to avoid focus ring looking
		15	outset to input element box.
		16
1	2011-09-06 Rob Buis <rbuis@rim.com>	17	2011-09-06 Rob Buis <rbuis@rim.com>
2		18
3	use after free in WebCore::SVGTRefElement::updateReferencedText	19	use after free in WebCore::SVGTRefElement::updateReferencedText

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +11 lines
		1	2011-09-06 Sameer Patil <mkrp87@motorola.com>
		2
		3	Padding size of input type search element is not locked on Webkit-GTK.
		4	https://bugs.webkit.org/show_bug.cgi?id=66937
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* fast/forms/search-styled-padding.html: Added.
		9	* platform/gtk/fast/forms/search-styled-expected.txt:
		10	* platform/gtk/fast/forms/search-styled-padding-expected.txt: Added.
		11
1	2011-09-06 Rob Buis <rbuis@rim.com>	12	2011-09-06 Rob Buis <rbuis@rim.com>
2		13
3	use after free in WebCore::SVGTRefElement::updateReferencedText	14	use after free in WebCore::SVGTRefElement::updateReferencedText

Line 0 LayoutTests/fast/forms/search-styled-padding.html_sec1
- LayoutTests/fast/forms/search-styled-padding.html +12 lines
	1	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	2	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
	3	<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
	4	<head>
	5	<style>
	6	.inputsearch{padding-left: 25px;padding-right: 25px;padding-top: 25px;padding-bottom: 25px;}
	7	</style>
	8	</head>
	9	<body>
	10	<input type="search" class="inputsearch" title="Input type Search element" value="" results="10" />
	11	</body>
	12	</html>

Lines 1-17 LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt_sec1
- LayoutTests/platform/gtk/fast/forms/search-styled-expected.txt -8 / +8 lines
1	layer at (0,0) size 800x600	1	layer at (0,0) size 800x600
2	RenderView at (0,0) size 800x600	2	RenderView at (0,0) size 800x600
3	layer at (0,0) size 800x41	3	layer at (0,0) size 800x38
4	RenderBlock {HTML} at (0,0) size 800x41	4	RenderBlock {HTML} at (0,0) size 800x38
5	RenderBody {BODY} at (8,8) size 784x25	5	RenderBody {BODY} at (8,8) size 784x22
6	RenderTextControl {INPUT} at (2,2) size 148x21 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]	6	RenderTextControl {INPUT} at (2,3) size 130x17 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
7	RenderDeprecatedFlexibleBox {DIV} at (18,4) size 126x13	7	RenderDeprecatedFlexibleBox {DIV} at (2,2) size 126x13
8	RenderBlock {DIV} at (0,1) size 11x11	8	RenderBlock {DIV} at (0,1) size 11x11
9	RenderBlock {DIV} at (11,0) size 104x13	9	RenderBlock {DIV} at (11,0) size 104x13
10	RenderBlock {DIV} at (115,1) size 11x11	10	RenderBlock {DIV} at (115,1) size 11x11
11	RenderText {#text} at (0,0) size 0x0	11	RenderText {#text} at (0,0) size 0x0
12	layer at (39,14) size 104x13	12	layer at (23,13) size 104x13
13	RenderBlock {DIV} at (0,0) size 104x13	13	RenderBlock {DIV} at (0,0) size 104x13
14	layer at (39,14) size 104x13	14	layer at (23,13) size 104x13
15	RenderBlock (relative positioned) {DIV} at (29,4) size 104x13 [color=#A9A9A9]	15	RenderBlock (relative positioned) {DIV} at (13,2) size 104x13 [color=#A9A9A9]
16	RenderText {#text} at (1,0) size 88x13	16	RenderText {#text} at (1,0) size 88x13
17	text run at (1,0) width 88: "Search for Events"	17	text run at (1,0) width 88: "Search for Events"