Attachment #105182 for bug #66937

View Details Raw Unified Return to Bug 66937

| Differences between



2011-08-25  Sameer Patil  <mkrp87@motorola.com>

        Locking padding size of input type search element on Webkit-GTK.
        https://bugs.webkit.org/show_bug.cgi?id=66937

        Reviewed by NOBODY (OOPS!).

        Test: fast/forms/search-styled-padding.html

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::adjustSearchFieldStyle):

2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r93771.

Lines 27-32 Source/WebCore/platform/gtk/RenderThemeGtk.cpp_sec1
- Source/WebCore/platform/gtk/RenderThemeGtk.cpp +9 lines
27		27
28	#include "CSSValueKeywords.h"	28	#include "CSSValueKeywords.h"
29	#include "FileSystem.h"	29	#include "FileSystem.h"
		30	#include "Frame.h"
30	#include "GOwnPtr.h"	31	#include "GOwnPtr.h"
31	#include "Gradient.h"	32	#include "Gradient.h"
32	#include "GraphicsContext.h"	33	#include "GraphicsContext.h"
Lines 364-369 void RenderThemeGtk::adjustSearchFieldSt Source/WebCore/platform/gtk/RenderThemeGtk.cpp_sec2
364	// We cannot give a proper rendering when border radius is active, unfortunately.	365	// We cannot give a proper rendering when border radius is active, unfortunately.
365	style->resetBorderRadius();	366	style->resetBorderRadius();
366	style->setLineHeight(RenderStyle::initialLineHeight());	367	style->setLineHeight(RenderStyle::initialLineHeight());
		368
		369	const int padding = 1;
		370	style->setPaddingLeft(Length(padding, Fixed));
		371	style->setPaddingRight(Length(padding, Fixed));
		372	style->setPaddingTop(Length(padding, Fixed));
		373	style->setPaddingBottom(Length(padding, Fixed));
		374	if (e && e->focused() && e->document()->frame()->selection()->isFocusedAndActive())
		375	style->setOutlineOffset(-2);
367	}	376	}
368		377
369	bool RenderThemeGtk::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& rect)	378	bool RenderThemeGtk::paintSearchField(RenderObject* o, const PaintInfo& i, const IntRect& rect)



2011-08-25  Sameer Patil  <mkrp87@motorola.com>

        Padding size of input type search element is not locked on Webkit-GTK.
        https://bugs.webkit.org/show_bug.cgi?id=66937

        Reviewed by NOBODY (OOPS!).

        * fast/forms/search-styled-padding-expected.txt: Added.
        * fast/forms/search-styled-padding.html: Added.

2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r93775.



layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x38
  RenderBlock {HTML} at (0,0) size 800x38
    RenderBody {BODY} at (8,8) size 784x22
      RenderTextControl {INPUT} at (2,3) size 130x17 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
        RenderDeprecatedFlexibleBox {DIV} at (2,2) size 126x13
          RenderBlock {DIV} at (0,1) size 11x11
          RenderBlock {DIV} at (11,0) size 104x13
          RenderBlock {DIV} at (115,1) size 11x11
      RenderText {#text} at (0,0) size 0x0
layer at (23,13) size 104x13
  RenderBlock {DIV} at (0,0) size 104x13
layer at (23,13) size 104x13
  RenderBlock (relative positioned) {DIV} at (13,2) size 104x13 [color=#A9A9A9]
    RenderText {#text} at (1,0) size 88x13
      text run at (1,0) width 88: "Search for Events"



<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
   "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
<style>
.inputtext,
.inputpassword{border:1px solid #bdc7d8;font-family:"lucida grande", tahoma, verdana, arial, sans-serif;font-size:11px;padding:3px;}
.inputsearch{background:white url(./resources/apple.gif) no-repeat 3px 4px;padding-left:17px;padding-bottom: 100px;}
</style>

</head>
<body>
<input type="search" class="inputtext inputsearch" title="Search for Events" placeholder="Search for Events" id="q_dashboard" name="q" value="" results="10" />
</body>
</html>

Return to Bug 66937

Lines 1-3 Source/WebCore/ChangeLog_sec1
- Source/WebCore/ChangeLog +12 lines
		1	2011-08-25 Sameer Patil <mkrp87@motorola.com>
		2
		3	Locking padding size of input type search element on Webkit-GTK.
		4	https://bugs.webkit.org/show_bug.cgi?id=66937
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	Test: fast/forms/search-styled-padding.html
		9
		10	* platform/gtk/RenderThemeGtk.cpp:
		11	(WebCore::RenderThemeGtk::adjustSearchFieldStyle):
		12
1	2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>	13	2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>
2		14
3	Unreviewed, rolling out r93771.	15	Unreviewed, rolling out r93771.

Lines 1-3 LayoutTests/ChangeLog_sec1
- LayoutTests/ChangeLog +10 lines
		1	2011-08-25 Sameer Patil <mkrp87@motorola.com>
		2
		3	Padding size of input type search element is not locked on Webkit-GTK.
		4	https://bugs.webkit.org/show_bug.cgi?id=66937
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* fast/forms/search-styled-padding-expected.txt: Added.
		9	* fast/forms/search-styled-padding.html: Added.
		10
1	2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>	11	2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>
2		12
3	Unreviewed, rolling out r93775.	13	Unreviewed, rolling out r93775.

Line 0 LayoutTests/fast/forms/search-styled-padding-expected.txt_sec1
- LayoutTests/fast/forms/search-styled-padding-expected.txt +17 lines
	1	layer at (0,0) size 800x600
	2	RenderView at (0,0) size 800x600
	3	layer at (0,0) size 800x38
	4	RenderBlock {HTML} at (0,0) size 800x38
	5	RenderBody {BODY} at (8,8) size 784x22
	6	RenderTextControl {INPUT} at (2,3) size 130x17 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
	7	RenderDeprecatedFlexibleBox {DIV} at (2,2) size 126x13
	8	RenderBlock {DIV} at (0,1) size 11x11
	9	RenderBlock {DIV} at (11,0) size 104x13
	10	RenderBlock {DIV} at (115,1) size 11x11
	11	RenderText {#text} at (0,0) size 0x0
	12	layer at (23,13) size 104x13
	13	RenderBlock {DIV} at (0,0) size 104x13
	14	layer at (23,13) size 104x13
	15	RenderBlock (relative positioned) {DIV} at (13,2) size 104x13 [color=#A9A9A9]
	16	RenderText {#text} at (1,0) size 88x13
	17	text run at (1,0) width 88: "Search for Events"

Line 0 LayoutTests/fast/forms/search-styled-padding.html_sec1
- LayoutTests/fast/forms/search-styled-padding.html +15 lines
	1	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
	2	"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
	3	<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
	4	<head>
	5	<style>
	6	.inputtext,
	7	.inputpassword{border:1px solid #bdc7d8;font-family:"lucida grande", tahoma, verdana, arial, sans-serif;font-size:11px;padding:3px;}
	8	.inputsearch{background:white url(./resources/apple.gif) no-repeat 3px 4px;padding-left:17px;padding-bottom: 100px;}
	9	</style>
	10
	11	</head>
	12	<body>
	13	<input type="search" class="inputtext inputsearch" title="Search for Events" placeholder="Search for Events" id="q_dashboard" name="q" value="" results="10" />
	14	</body>
	15	</html>